Bug 24056

Summary:	Capitalization: Cash Register ID on cash register management page
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Templates	Assignee:	Lisette Scheer <lisettepalouse+koha>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	1joynelson, george, lisettepalouse+koha, martin.renvoize
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	20.05.00, 19.11.01
Circulation function:
Attachments:	Bug 24056 : Capitalization: Cash Register ID on cash register management page Bug 24056 : Capitalization: Cash Register ID on cash register management page When editing a cash register, Cash register ID doesn't follow our capitalization guidelines. This patch fixes that. To Test: 1) Turn on cash register usage in the system prefere Bug 24056: Capitalization: Cash Register ID on cash register management page

Description Katrin Fischer 2019-11-18 12:40:14 UTC

When editing a cash register, there is:
Cash Register ID:␠

This should be: Cash register ID to follow our capitalization guidelines.

Make sure you have activated cash registers via system preferences, add a cash register and edit it.

Comment 1 Lisette Scheer 2019-11-19 18:36:04 UTC

Created attachment 95587 [details] [review]
Bug 24056 : Capitalization: Cash Register ID on cash register management page

When editing a cash register, Cash register ID doesn't follow our capitalization guidelines. This patch fixes that. 
To Test: 
1) Turn on cash register usage in the system preferences. 
2) Add a cash register. 
3) Edit the cash register. 
4) Note the incorrect capitalization. 
5) Apply the patch. 
6) Edit the cash register. 
7) Note the correct capitalization.

Comment 2 PTFS Europe Sandboxes 2019-11-22 04:51:43 UTC

Created attachment 95709 [details] [review]
Bug 24056 : Capitalization: Cash Register ID on cash register management page When editing a cash register, Cash register ID doesn't follow our capitalization guidelines. This patch fixes that. To Test: 1) Turn on cash register usage in the system prefere

https://bugs.koha-community.org/show_bug.cgi?id=6473

Signed-off-by: George Williams <george@nekls.org>

Comment 3 Katrin Fischer 2019-11-22 21:11:51 UTC

Created attachment 95745 [details] [review]
Bug 24056: Capitalization: Cash Register ID on cash register management page

When editing a cash register, Cash register ID doesn't follow
our capitalization guidelines. This patch fixes that.

To Test:
1) Turn on cash register usage in the system preferences.
2) Add a cash register.
3) Edit the cash register.
4) Note the incorrect capitalization.
5) Apply the patch.
6) Edit the cash register.
7) Note the correct capitalization.

Signed-off-by: George Williams <george@nekls.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Martin Renvoize (ashimema) 2019-12-09 14:35:56 UTC

Nice work everyone!

Pushed to master for 20.05

Comment 5 Joy Nelson 2019-12-11 20:17:46 UTC

Pushed to 19.11.01