| Summary: | Koha::Patron->has_permission has no POD | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 17454 | ||
| Attachments: |
Bug 24066: Add missing POD for has_permission
Bug 24066: Add missing POD for has_permission Bug 24066: Add missing POD for has_permission |
||
|
Description
Martin Renvoize (ashimema)
2019-11-19 14:01:05 UTC
Created attachment 95552 [details] [review] Bug 24066: Add missing POD for has_permission Created attachment 99673 [details] [review] Bug 24066: Add missing POD for has_permission To test: 1) do perldoc Koha/Patron.pm search has_permission Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Fixed (removed) space before 'my $permission' to make it similar to other entries. No errors Thanks Bernardo.. Hmm, perhaps I should do an indent on the rest of the aPOD entriws.. the indentation is actually a POD formatting thing, it denotes 'codeblock' =POD See also =cut Great! :) Created attachment 100251 [details] [review] Bug 24066: Add missing POD for has_permission To test: 1) do perldoc Koha/Patron.pm search has_permission Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Fixed (removed) space before 'my $permission' to make it similar to other entries. No errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to master for 20.05 I encounter a qa error with this patch
FAIL Koha/Patron.pm
OK critic
OK forbidden patterns
OK git manipulation
OK pod
FAIL pod coverage
POD is missing for 'trim_whitespaces'
OK spelling
OK valid
not backporting to 19.11.x
|