| Summary: | Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | I18N/L10N | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | f.demians, martin.renvoize |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 15395 | ||
| Bug Blocks: | 23591 | ||
| Attachments: |
Bug 24068: Fix I18 plugin - tnpx must call __npx
Bug 24068: Fix I18 plugin - tnpx must call __npx Bug 24068: (RM follow-up) Enhance the POD Bug 24068: (RM follow-up) Enhance the POD |
||
|
Description
Jonathan Druart
2019-11-19 16:25:16 UTC
Created attachment 95578 [details] [review] Bug 24068: Fix I18 plugin - tnpx must call __npx Test plan: Use the following code to test this change [% PROCESS 'i18n.inc' %] [% SET nb_stuffs = 1 %] [% tnpx('context', 'There is one stuff.', 'There are {count} stuffs.', nb_stuffs, { count = nb_stuffs }) | $raw %] [% SET nb_stuffs = 42 %] [% tnpx('context', 'There is one stuff.', 'There are {count} stuffs.', nb_stuffs, { count = nb_stuffs }) | $raw %] Compare with and without the patch Created attachment 95729 [details] [review] Bug 24068: Fix I18 plugin - tnpx must call __npx Test plan: Use the following code to test this change [% PROCESS 'i18n.inc' %] [% SET nb_stuffs = 1 %] [% tnpx('context', 'There is one stuff.', 'There are {count} stuffs.', nb_stuffs, { count = nb_stuffs }) | $raw %] [% SET nb_stuffs = 42 %] [% tnpx('context', 'There is one stuff.', 'There are {count} stuffs.', nb_stuffs, { count = nb_stuffs }) | $raw %] Compare with and without the patch Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 95730 [details] [review] Bug 24068: (RM follow-up) Enhance the POD Works well and is an obvious correction to a typo.. Signing off and Passing QA in one hit... I've also enhanced the documentation for the module a bit. Created attachment 95731 [details] [review] Bug 24068: (RM follow-up) Enhance the POD Nice work! Pushed to master for 19.11.00 |