|
Description
Martin Renvoize (ashimema)
2019-11-21 11:12:13 UTC
Created attachment 95665 [details] [review] Bug 24080: Payout account debit type Created attachment 95666 [details] [review] Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff Created attachment 95667 [details] [review] Bug 24080: Add account_payout permission Created attachment 95668 [details] [review] Bug 24080: Add payout option to patron account page Created attachment 95669 [details] [review] Bug 24080: Payout account debit type Created attachment 95670 [details] [review] Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff Created attachment 95671 [details] [review] Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. Created attachment 95672 [details] [review] Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff > Test Plan:
> 1) Run the included tests and verify they pass.
I can't seem to find which tests this refers to. Could they be missing?
Created attachment 95793 [details] [review] Bug 24080: Payout account debit type Created attachment 95794 [details] [review] Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff Created attachment 95795 [details] [review] Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. Created attachment 95796 [details] [review] Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff Oops, seems I managed to miss committing the tests.. I've corrected that now.. thanks for bringing it to my attention. Created attachment 96332 [details] [review] Bug 24080: Payout account debit type Created attachment 96333 [details] [review] Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff Created attachment 96334 [details] [review] Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. Created attachment 96335 [details] [review] Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff Question.. should we prevent staff from paying out to themselves as a security measure? Created attachment 96519 [details] [review] Bug 24080: Payout account debit type Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 96520 [details] [review] Bug 24080: Payout account debit type Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 96521 [details] [review] Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 96522 [details] [review] Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 96523 [details] [review] Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 96597 [details] [review] Bug 24080: Payout account debit type Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96598 [details] [review] Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96599 [details] [review] Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96600 [details] [review] Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96601 [details] [review] Bug 24080: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96602 [details] [review] Bug 24080: Adjust text in modal Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96605 [details] [review] Bug 24080: Payout account debit type Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96606 [details] [review] Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96607 [details] [review] Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96608 [details] [review] Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96609 [details] [review] Bug 24080: Adjust text in modal Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 96610 [details] [review] Bug 24080: (QA follow-up) Remove processing for removed field Created attachment 96748 [details] [review] Bug 24080: Payout account debit type Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96749 [details] [review] Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96750 [details] [review] Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96751 [details] [review] Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 96752 [details] [review] Bug 24080: Adjust text in modal Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 96753 [details] [review] Bug 24080: (QA follow-up) Remove processing for removed field Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Nice work everyone! Pushed to master for 20.05 Nice work everyone! Pushed to master for 20.05 not backported to 19.11.x |