Summary: | Template vars are incorrectly html filtered when dumped | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, lucas |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.04, 19.05.09
|
|
Circulation function: | |||
Bug Depends on: | 13618 | ||
Bug Blocks: | |||
Attachments: |
Bug 24110: Do not html filter TT vars when dumped
Bug 24110: Do not html filter TT vars when dumped Bug 24110: Do not html filter TT vars when dumped |
Description
Jonathan Druart
2019-11-26 08:24:36 UTC
Created attachment 95809 [details] [review] Bug 24110: Do not html filter TT vars when dumped DumpTemplateVarsIntranet and DumpTemplateVarsOpac are devs tools to display the variables sent to the template. They should not be filtered otherwise it's getting completed to read. For instance: $VAR1 = { var => val } Test plan: Turn DumpTemplateVarsIntranet on Go to the main page Show the source of the page Confirm that the variable are displayed as it and not filtered Created attachment 98962 [details] [review] Bug 24110: Do not html filter TT vars when dumped DumpTemplateVarsIntranet and DumpTemplateVarsOpac are devs tools to display the variables sent to the template. They should not be filtered otherwise it's getting completed to read. For instance: $VAR1 = { var => val } Test plan: Turn DumpTemplateVarsIntranet on Go to the main page Show the source of the page Confirm that the variable are displayed as it and not filtered Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Confirmed variable is not filtered. Fixed a little error on opac file (changed Use -> USE) No other errors Created attachment 99135 [details] [review] Bug 24110: Do not html filter TT vars when dumped DumpTemplateVarsIntranet and DumpTemplateVarsOpac are devs tools to display the variables sent to the template. They should not be filtered otherwise it's getting complicate to read. For instance: $VAR1 = { var => val } Test plan: Turn DumpTemplateVarsIntranet on Go to the main page Show the source of the page Confirm that the variable are displayed as it and not filtered Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Confirmed variable is not filtered. Fixed a little error on opac file (changed Use -> USE) No other errors Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x for 19.11.04 backported to 19.05.x for 19.05.09 |