Bug 24113

Summary: guarantor info lost when a duplicate is found
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: PatronsAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: emmi.takkinen, gmcharlt, kyle.m.hall, martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26558
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Bug Depends on: 14570    
Bug Blocks:    
Attachments: Bug 24113: guarantor info lost when a duplicate is found
Bug 24113: guarantor info lost when a duplicate is found
Bug 24113: guarantor info lost when a duplicate is found

Description Jonathan Druart 2019-11-26 09:23:48 UTC
When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost.

To recreate:
Create a patron with surname=toto
Create a kid with surname=toto and a guarantor
Save
Confirm that you want to create a new record
=> The guarantor info is not saved

It works prior to bug 14570.
Comment 1 Kyle M Hall 2019-11-26 15:28:12 UTC
Created attachment 95834 [details] [review]
Bug 24113: guarantor info lost when a duplicate is found

When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost.

This patch improves on previous functionality by retaining the select guarantor relationship as well.

Test Plan:
1) Create a new child with a name already used, add a guarantor
2) Attempt to save, no the guarantor is not shown when the editor is redisplayed
3) Apply this patch
4) Restart all the things!
5) Repeat 1
6) Note the guarantor is retained and the relationship is as well!
Comment 2 Jonathan Druart 2019-11-26 15:57:22 UTC
Created attachment 95835 [details] [review]
Bug 24113: guarantor info lost when a duplicate is found

When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost.

This patch improves on previous functionality by retaining the select guarantor relationship as well.

Test Plan:
1) Create a new child with a name already used, add a guarantor
2) Attempt to save, no the guarantor is not shown when the editor is redisplayed
3) Apply this patch
4) Restart all the things!
5) Repeat 1
6) Note the guarantor is retained and the relationship is as well!

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Martin Renvoize 2019-11-27 07:51:49 UTC
Created attachment 95843 [details] [review]
Bug 24113: guarantor info lost when a duplicate is found

When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost.

This patch improves on previous functionality by retaining the select guarantor relationship as well.

Test Plan:
1) Create a new child with a name already used, add a guarantor
2) Attempt to save, no the guarantor is not shown when the editor is redisplayed
3) Apply this patch
4) Restart all the things!
5) Repeat 1
6) Note the guarantor is retained and the relationship is as well!

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2019-11-27 07:52:10 UTC
Thanks for the quick fix, Passing QA and Pushing.
Comment 5 Martin Renvoize 2019-11-27 07:52:37 UTC
Nice work!

Pushed to master for 19.11.00