Bug 24120

Summary: Search terms in search dropdown must be URI filtered
Product: Koha Reporter: Nick Clemens <nick>
Component: SearchingAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: hayleypelham, jonathan.druart, lucas, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00, 19.05.06, 18.11.12
Bug Depends on: 21526    
Bug Blocks:    
Attachments: Bug 24120: URI filter search terms in sort dropdowns
Bug 24120: URI filter search terms in sort dropdowns
Bug 24120: (follow-up) input_name too
Bug 24120: (follow-up) input_name too
Bug 24120: URI filter search terms in sort dropdowns
Bug 24120: (follow-up) input_name too

Description Nick Clemens 2019-11-26 13:19:20 UTC
To recreate:
1 - Search for C++
2 - Sort your results
3 - Note search is now for "C  "
Comment 1 Nick Clemens 2019-11-26 13:21:19 UTC
Created attachment 95826 [details] [review]
Bug 24120: URI filter search terms in sort dropdowns

To test:
1 - Search for C++
2 - Sort your results
3 - Note search is now for "C  "
4 - Apply patch
5 - Search for C++
6 - Reorder results
7 - Still searching for C++
Comment 2 Tomás Cohen Arazi 2019-11-26 13:32:44 UTC
Created attachment 95828 [details] [review]
Bug 24120: URI filter search terms in sort dropdowns

To test:
1 - Search for C++
2 - Sort your results
3 - Note search is now for "C  "
4 - Apply patch
5 - Search for C++
6 - Reorder results
7 - Still searching for C++

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Jonathan Druart 2019-11-26 14:07:29 UTC
Why not QUERY_INPUT.input_name as well?
Comment 4 Nick Clemens 2019-11-26 14:12:22 UTC
Created attachment 95830 [details] [review]
Bug 24120: (follow-up) input_name too
Comment 5 Tomás Cohen Arazi 2019-11-26 14:32:40 UTC
Created attachment 95831 [details] [review]
Bug 24120: (follow-up) input_name too

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Jonathan Druart 2019-11-26 14:52:23 UTC
Created attachment 95832 [details] [review]
Bug 24120: URI filter search terms in sort dropdowns

To test:
1 - Search for C++
2 - Sort your results
3 - Note search is now for "C  "
4 - Apply patch
5 - Search for C++
6 - Reorder results
7 - Still searching for C++

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2019-11-26 14:52:27 UTC
Created attachment 95833 [details] [review]
Bug 24120: (follow-up) input_name too

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Martin Renvoize 2019-11-27 07:55:13 UTC
Nice work!

Pushed to master for 19.11.00
Comment 9 Lucas Gass 2019-12-10 22:27:35 UTC
backported to 19.05.x for 19.05.06
Comment 10 Hayley Pelham 2019-12-17 01:17:12 UTC
Backported to 18.11.x for 18.11.12