| Summary: | Cannot select authorities in batch deletion tool in Chrome | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Tools | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, jonathan.druart, lucas, oleonard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.01
|
|
| Circulation function: | |||
| Bug Depends on: | 12759 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 24124: Cannot select authorities in batch deletion tool in Chrome
Bug 24124: Cannot select authorities in batch deletion tool in Chrome Bug 24124: Cannot select authorities in batch deletion tool in Chrome Bug 24124: Fix authorities selection in batch deletion tool in Chrome |
||
|
Description
Nick Clemens (kidclamp)
2019-11-26 14:33:00 UTC
It's caused by the use of toptabs. I do not understand what is going on here. It also affects Batch record modification. Created attachment 95926 [details] [review] Bug 24124: Cannot select authorities in batch deletion tool in Chrome This patch adds some inline CSS to force clearing on some elements in the forms for batch record modification and deletion. The problem with selecting the "Authorities" radio button stemmed from the fact that non-clearing floats caused elements to invisibly overlap in the form. To test, apply the patch and test both batch record modification and batch record deletion. Upon selecting the "Authorities" radio button in each case the "Select a list of records" tab should disappear. Selecting the "Biblios" option should re-display the tab. Created attachment 95985 [details] [review] Bug 24124: Cannot select authorities in batch deletion tool in Chrome This patch adds some inline CSS to force clearing on some elements in the forms for batch record modification and deletion. The problem with selecting the "Authorities" radio button stemmed from the fact that non-clearing floats caused elements to invisibly overlap in the form. To test, apply the patch and test both batch record modification and batch record deletion. Upon selecting the "Authorities" radio button in each case the "Select a list of records" tab should disappear. Selecting the "Biblios" option should re-display the tab. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Good easy fix, thanks Owen. Created attachment 96009 [details] [review] Bug 24124: Cannot select authorities in batch deletion tool in Chrome This patch adds some inline CSS to force clearing on some elements in the forms for batch record modification and deletion. The problem with selecting the "Authorities" radio button stemmed from the fact that non-clearing floats caused elements to invisibly overlap in the form. To test, apply the patch and test both batch record modification and batch record deletion. Upon selecting the "Authorities" radio button in each case the "Select a list of records" tab should disappear. Selecting the "Biblios" option should re-display the tab. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 96013 [details] [review] Bug 24124: Fix authorities selection in batch deletion tool in Chrome This patch adds some inline CSS to force clearing on some elements in the forms for batch record modification and deletion. The problem with selecting the "Authorities" radio button stemmed from the fact that non-clearing floats caused elements to invisibly overlap in the form. To test, apply the patch and test both batch record modification and batch record deletion. Upon selecting the "Authorities" radio button in each case the "Select a list of records" tab should disappear. Selecting the "Biblios" option should re-display the tab. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.01 |