Bug 24130

Summary: Update 18.12.00.024 can fail due to bad date data
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: DatabaseAssignee: Martin Renvoize <martin.renvoize>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: blocker    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Attachments: Bug 24130: (RM follow-up) Fix old invalid data

Description Martin Renvoize 2019-11-27 15:33:26 UTC
DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_suggestedbyFOREIGN KEY (suggestedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17646.
DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_managedbyFOREIGN KEY (managedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17657.
DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_acceptedbyFOREIGN KEY (acceptedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17669. 
DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_rejectedbyFOREIGN KEY (rejectedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17681.
DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_biblionumberFOREIGN KEY (biblionumber) REFERENCESbiblio(biblionumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17693.
DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_branchcodeFOREIGN KEY (branchcode) REFERENCESbranches(branchcode) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17705.

This is undoubtedly due to bad data having been left behind after bug 12627.

I think the most pragmatic approach is to just update any such values with a default date far in the past.
Comment 1 Martin Renvoize 2019-11-27 15:55:10 UTC
Created attachment 95850 [details] [review]
Bug 24130: (RM follow-up) Fix old invalid data

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>