|
Description
Matthias Meusburger
2019-12-02 16:06:11 UTC
Created attachment 95927 [details] [review] Bug 24143: Disable QueryXXX when searching on a identifier. Using the ident or identifier-standard index should not involve any of the following features: - QueryAutoTruncate - QueryFuzzy - QueryStemming - QueryWeightFields Created attachment 97311 [details] [review] Bug 24143: Disable QueryXXX when searching on a identifier. Using the ident or identifier-standard index should not involve any of the following features: - QueryAutoTruncate - QueryFuzzy - QueryStemming - QueryWeightFields Created attachment 97323 [details] [review] Bug 24143: Disable QueryXXX when searching on a identifier. Using the ident or identifier-standard index should not involve any of the following features: - QueryAutoTruncate - QueryFuzzy - QueryStemming - QueryWeightFields Created attachment 109185 [details] [review] Bug 24143: Disable QueryXXX when searching on a authority number Using the ident or identifier-standard index should not involve any of the following features: - QueryAutoTruncate - QueryFuzzy - QueryStemming - QueryWeightFields This is used in autorities search table to display use count. Created attachment 109186 [details] [review] Bug 24143: Disable QueryXXX when searching on an authority number Using the ident or identifier-standard index should not involve any of the following features: - QueryAutoTruncate - QueryFuzzy - QueryStemming - QueryWeightFields This is used in autorities search table to display use count. This as a huge impact with Elasticsearch with QueryAutoTruncate If I recall correctly, the QueryXXX settings are set in the wrong scope in buildQuery. It's a long term goal to fix that one day... At the moment, the problem with patches like this is they'll disable QueryXXX settings for unrelated indexes on complex queries. (At least if it still works the way it used to... I suppose it's always possible things have changed since I last looked.) 1. There is a conflict: $ git bz apply 24143 Bug 24143 - buildQuery should disable Query* on identifier search 97323 - Bug 24143: Disable QueryXXX when searching on a identifier. 109186 - Bug 24143: Disable QueryXXX when searching on an authority number Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24143: Disable QueryXXX when searching on a identifier. Using index info to reconstruct a base tree... M C4/Search.pm Falling back to patching base and 3-way merge... Auto-merging C4/Search.pm CONFLICT (content): Merge conflict in C4/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 24143: Disable QueryXXX when searching on a identifier. hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-24143-Disable-QueryXXX-when-searching-on-a-ide-M7wS8V.patch 2. I think I fixed the conflict, but testing showed no difference. Here is how I tested: - Find a record with an ISBN - Add the same ISBN to another record, but change the last digit - Search for the original ISBN and get both the original record and the record with the slightly changed ISBN as result - Apply the patch, restart_all and reindex (should not be necessary?) - Same result So maybe a rebase and a test plan? :-) Obsolete since Bug 32707 ? |