Summary: | Objects.t is failing randomly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, lucas, martin.renvoize, tomascohen, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04, 19.11.10, 19.05.15
|
|
Bug Depends on: | |||
Bug Blocks: | 25551 | ||
Attachments: |
Bug 24147: Don't assume search_related will return ordered values
Bug 24147: Don't assume search_related will return ordered values Bug 24147: Don't assume search_related will return ordered values |
Description
Jonathan Druart
2019-12-03 14:22:45 UTC
I think this has been fixed, it did not reappeared. Master_U18 #799 15:20:29 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 15:20:29 koha_1 | # at t/db_dependent/Koha/Objects.t line 148. 15:20:29 koha_1 | # got: 'Jj0uPsF0y' 15:20:29 koha_1 | # expected: 'p_qV3ggA' 15:20:29 koha_1 | 15:20:29 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 15:20:29 koha_1 | # at t/db_dependent/Koha/Objects.t line 149. 15:20:29 koha_1 | # got: 'p_qV3ggA' 15:20:29 koha_1 | # expected: 'Jj0uPsF0y' 15:20:29 koha_1 | 15:20:29 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 15:20:29 koha_1 | # at t/db_dependent/Koha/Objects.t line 154. 15:20:29 koha_1 | # got: 'Jj0uPsF0y' 15:20:29 koha_1 | # expected: 'p_qV3ggA' 15:20:29 koha_1 | 15:20:29 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 15:20:29 koha_1 | # at t/db_dependent/Koha/Objects.t line 155. 15:20:29 koha_1 | # got: 'p_qV3ggA' 15:20:29 koha_1 | # expected: 'Jj0uPsF0y' 15:20:29 koha_1 | # Looks like you failed 4 tests of 8. 15:20:29 koha_1 | 15:20:29 koha_1 | # Failed test 'search_related' 15:20:29 koha_1 | # at t/db_dependent/Koha/Objects.t line 156. 15:21:05 koha_1 | # Looks like you failed 1 test of 23. 15:21:05 koha_1 | [13:21:05] t/db_dependent/Koha/Objects.t 19.11_D9 #193 01:35:33 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 01:35:33 koha_1 | # at t/db_dependent/Koha/Objects.t line 152. 01:35:33 koha_1 | # got: 'q_H6M1k' 01:35:33 koha_1 | # expected: 'qqXKWFD1GF' 01:35:33 koha_1 | 01:35:33 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 01:35:33 koha_1 | # at t/db_dependent/Koha/Objects.t line 153. 01:35:33 koha_1 | # got: 'qqXKWFD1GF' 01:35:33 koha_1 | # expected: 'q_H6M1k' 01:35:33 koha_1 | 01:35:33 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 01:35:33 koha_1 | # at t/db_dependent/Koha/Objects.t line 158. 01:35:33 koha_1 | # got: 'q_H6M1k' 01:35:33 koha_1 | # expected: 'qqXKWFD1GF' 01:35:33 koha_1 | 01:35:33 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 01:35:33 koha_1 | # at t/db_dependent/Koha/Objects.t line 159. 01:35:33 koha_1 | # got: 'qqXKWFD1GF' 01:35:33 koha_1 | # expected: 'q_H6M1k' 01:35:33 koha_1 | # Looks like you failed 4 tests of 8. 01:35:33 koha_1 | 01:35:33 koha_1 | # Failed test 'search_related' 01:35:33 koha_1 | # at t/db_dependent/Koha/Objects.t line 160. 01:35:43 koha_1 | # Looks like you failed 1 test of 17. 01:35:43 koha_1 | [23:35:43] t/db_dependent/Koha/Objects.t Koha_Master_U16 #45 (Docker_1) - 10.1.46-MariaDB-1~bionic From yesterday, 19.05_U18 #274 (Docker_4) Created attachment 108735 [details] [review] Bug 24147: Don't assume search_related will return ordered values This test is failing randomly because it assume the order is always the same. But it's not. Note: Koha::Objects->search_related is never used , last use removed from commit 9aa724cdf29a57bc91e42b240b5bcd19e3814ada Bug 19599: Speed anonymise_issue_history up We should keep it however IMO Created attachment 109371 [details] [review] Bug 24147: Don't assume search_related will return ordered values This test is failing randomly because it assume the order is always the same. But it's not. Note: Koha::Objects->search_related is never used , last use removed from commit 9aa724cdf29a57bc91e42b240b5bcd19e3814ada Bug 19599: Speed anonymise_issue_history up We should keep it however IMO Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 109381 [details] [review] Bug 24147: Don't assume search_related will return ordered values This test is failing randomly because it assume the order is always the same. But it's not. Note: Koha::Objects->search_related is never used , last use removed from commit 9aa724cdf29a57bc91e42b240b5bcd19e3814ada Bug 19599: Speed anonymise_issue_history up We should keep it however IMO Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 backported to 19.11.x for 19.11.10 Backported to 19.05.x branch for 19.05.15 Still failing, U16 run 263 on Docker_2 17:29:23 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 17:29:23 koha_1 | # at t/db_dependent/Koha/Objects.t line 161. 17:29:23 koha_1 | 17:29:23 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 17:29:23 koha_1 | # at t/db_dependent/Koha/Objects.t line 181. 17:29:23 koha_1 | # Looks like you failed 2 tests of 6. 17:29:23 koha_1 | 17:29:23 koha_1 | # Failed test 'search_related' 17:29:23 koha_1 | # at t/db_dependent/Koha/Objects.t line 184. Again on U16 run 276 on Docker_6 U16 278 Docker_2 U_Stable 181, Docker_3 Master_U18 1110 Docker_1 Master_U_Stable 196 Docker_1 Koha_20.05_U16 309 Docker_4 https://jenkins.koha-community.org/view/20.05/job/Koha_20.05_U16/309/consoleText Is that actually an instance of this bug? koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' koha_1 | # at t/db_dependent/Koha/Objects.t line 160. koha_1 | koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' koha_1 | # at t/db_dependent/Koha/Objects.t line 180. koha_1 | # Looks like you failed 2 tests of 6. koha_1 | koha_1 | # Failed test 'search_related' koha_1 | # at t/db_dependent/Koha/Objects.t line 183. koha_1 | # Looks like you failed 1 test of 23. koha_1 | [00:45:47] t/db_dependent/Koha/Objects.t ........................................... koha_1 | Dubious, test returned 1 (wstat 256, 0x100) koha_1 | Failed 1/23 subtests (In reply to Victor Grousset/tuxayo from comment #19) > Is that actually an instance of this bug? Yes. Koha_Master_D11_My8/686 Docker_2 13:24:48 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 13:24:48 koha_1 | # at t/db_dependent/Koha/Objects.t line 163. 13:24:48 koha_1 | 13:24:48 koha_1 | # Failed test 'Koha::Objects->search_related should work as expected' 13:24:48 koha_1 | # at t/db_dependent/Koha/Objects.t line 183. 13:24:48 koha_1 | # Looks like you failed 2 tests of 6. 13:24:48 koha_1 | 13:24:48 koha_1 | # Failed test 'search_related' 13:24:48 koha_1 | # at t/db_dependent/Koha/Objects.t line 186. |