|
Description
Kyle M Hall (khall)
2019-12-03 20:16:44 UTC
Created attachment 95984 [details] [review] Bug 24165: Add ability to send any item field in a library chosen SIP field Some SIP devices need access to item fields that are not sent as item information in the checkin, checkout and item information responses. It makes sense to allow these fields to be sent in an arbitrary and configurable way, rather than hard code in each special case. Test Plan: 1) Apply this patch 2) Edit your SIP2 config file, add the following within the login stanza: <item_field field="XX" code="<item field 1>" /> <item_field field="XZ" code="<item fied 2>" /> where <item field 1> and <item field 2> are item table columns of your choosing 3) Using the sip cli emulator, run checkout, checkin and item information messages using that item. 4) Note the values you set for the item columns are sent in the corrosponding fields! Created attachment 99256 [details] [review] Bug 24165: Add ability to send any item field in a library chosen SIP field Some SIP devices need access to item fields that are not sent as item information in the checkin, checkout and item information responses. It makes sense to allow these fields to be sent in an arbitrary and configurable way, rather than hard code in each special case. Test Plan: 1) Apply this patch 2) Edit your SIP2 config file, add the following within the login stanza: <item_field field="XX" code="<item field 1>" /> <item_field field="XZ" code="<item fied 2>" /> where <item field 1> and <item field 2> are item table columns of your choosing 3) Using the sip cli emulator, run checkout, checkin and item information messages using that item. 4) Note the values you set for the item columns are sent in the corrosponding fields! Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org> Created attachment 106931 [details] [review] Bug 24165: Add ability to send any item field in a library chosen SIP field Some SIP devices need access to item fields that are not sent as item information in the checkin, checkout and item information responses. It makes sense to allow these fields to be sent in an arbitrary and configurable way, rather than hard code in each special case. Test Plan: 1) Apply this patch 2) Edit your SIP2 config file, add the following within the login stanza: <item_field field="XX" code="<item field 1>" /> <item_field field="XZ" code="<item fied 2>" /> where <item field 1> and <item field 2> are item table columns of your choosing 3) Using the sip cli emulator, run checkout, checkin and item information messages using that item. 4) Note the values you set for the item columns are sent in the corrosponding fields! Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> qa-tools.pl incorrectly complains
> FAIL pod coverage
> POD is missing for build_additional_item_fields_string
this is because SIP server code still has few files with separate .pod files so qa tool is checking if it exists there and not if it exists in the source code. I think it is outside of the scope of this bug to move the POD comments to source code files so passing QA.
Created attachment 106932 [details] [review] Bug 24165: Add ability to send any item field in a library chosen SIP field Some SIP devices need access to item fields that are not sent as item information in the checkin, checkout and item information responses. It makes sense to allow these fields to be sent in an arbitrary and configurable way, rather than hard code in each special case. Test Plan: 1) Apply this patch 2) Edit your SIP2 config file, add the following within the login stanza: <item_field field="XX" code="<item field 1>" /> <item_field field="XZ" code="<item fied 2>" /> where <item field 1> and <item field 2> are item table columns of your choosing 3) Using the sip cli emulator, run checkout, checkin and item information messages using that item. 4) Note the values you set for the item columns are sent in the corrosponding fields! Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org> Fixed merge conflict with number of tests (was 4, changed to 7 which is correct) Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 106934 [details] [review] Bug 24165: Add ability to send any item field in a library chosen SIP field Some SIP devices need access to item fields that are not sent as item information in the checkin, checkout and item information responses. It makes sense to allow these fields to be sent in an arbitrary and configurable way, rather than hard code in each special case. Test Plan: 1) Apply this patch 2) Edit your SIP2 config file, add the following within the login stanza: <item_field field="XX" code="<item field 1>" /> <item_field field="XZ" code="<item fied 2>" /> where <item field 1> and <item field 2> are item table columns of your choosing 3) Using the sip cli emulator, run checkout, checkin and item information messages using that item. 4) Note the values you set for the item columns are sent in the corrosponding fields! Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org> Fixed merge conflict with number of tests (was 5, changed to 7 which is correct) Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Sorry for the extra patch attachments. I added a note about solving merge conflict. This is now ready for RM to push. Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 enhancement, not backported to 19.11.x |