Summary: | Barcode removal breaks circulation.pl/moremember.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, gmcharlt, hayleypelham, jonathan.druart, kyle.m.hall, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.00, 19.11.02, 19.05.07, 18.11.13
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 25291 | ||
Attachments: |
Bug 24166: Do not hang when displaying checkout list if barcode is not set
Bug 24166: Do not hang when displaying checkout list if barcode is not set Bug 24166: Do not hang when displaying checkout list if barcode is not set |
Description
Christopher Brannon
2019-12-03 22:07:31 UTC
Created attachment 96409 [details] [review] Bug 24166: Do not hang when displaying checkout list if barcode is not set If a barcode is not set, there is a JS error in the log: TypeError: oObj.barcode is null We should not call escapeHtml() on it if not barcode is set for a given item. Test plan: Check an item out Remove its barcode Load the checkout list => Without this patch you get the "loading" popup and the table is never displayed => With this patch applied you see the checkout list Created attachment 96413 [details] [review] Bug 24166: Do not hang when displaying checkout list if barcode is not set If a barcode is not set, there is a JS error in the log: TypeError: oObj.barcode is null We should not call escapeHtml() on it if not barcode is set for a given item. Test plan: Check an item out Remove its barcode Load the checkout list => Without this patch you get the "loading" popup and the table is never displayed => With this patch applied you see the checkout list Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 96590 [details] [review] Bug 24166: Do not hang when displaying checkout list if barcode is not set If a barcode is not set, there is a JS error in the log: TypeError: oObj.barcode is null We should not call escapeHtml() on it if not barcode is set for a given item. Test plan: Check an item out Remove its barcode Load the checkout list => Without this patch you get the "loading" popup and the table is never displayed => With this patch applied you see the checkout list Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.02 backported to 19.05.x for 19.05.07 Backported to 18.11.x for 18.11.13 |