Bug 24177

Confirmed on master - marking blocker as this breaks a major feature in our new stable release:

Can't locate object method "search" via package "Koha::Account::CreditTypes" (perhaps you forgot to load "Koha::Account::CreditTypes"?) at /home/vagrant/kohaclone/reports/cash_register_stats.pl line 61

Created attachment 96132 [details] [review]
Bug 24177: Import Koha::Account::CreditTypes to cash_register_stats.pl

Test plan:
0) Do not apply the patch
1) Confirm the bug - go to Reports -> Cash register
--> You will see ISE
2) Apply the patch, and restart_all
3) Confirm the ISE is gone and you see the form for Cash register report

Created attachment 96157 [details] [review]
Bug 24177: Import Koha::Account::CreditTypes to cash_register_stats.pl

Test plan:
0) Do not apply the patch
1) Confirm the bug - go to Reports -> Cash register
--> You will see ISE
2) Apply the patch, and restart_all
3) Confirm the ISE is gone and you see the form for Cash register report

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Created attachment 96161 [details] [review]
Bug 24177: Import Koha::Account::CreditTypes to cash_register_stats.pl

Test plan:
0) Do not apply the patch
1) Confirm the bug - go to Reports -> Cash register
--> You will see ISE
2) Apply the patch, and restart_all
3) Confirm the ISE is gone and you see the form for Cash register report

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Created attachment 96162 [details] [review]
Bug 24177: (QA follow-up) Fix warning

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

You beat me to it, yeay.. go team :).. It's been a day of that.. every bug on my list has been done just before I get to it :)

Nice work everyone!

Pushed to master for 20.05

Pushed to 19.11.01

missing dependencies for 19.05.x, no backport

Software error when clicking cash register 19.11.01
an't locate object method "search" via package "Koha::Account::CreditTypes" (perhaps you forgot to load "Koha::Account::CreditTypes"?) at /usr/share/koha/intranet/cgi-bin/reports/cash_register_stats.pl line 61.

I've just checked, the fix has been pushed to 19.11.01 - can you double check the version you have installed please? It's listed on the About page.

http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=81403f461278d41b107589fa261247b6e37f581a

Dear sir
I am upgrade koha 19.11.00 to 19.11.01 but no upgrade your site.please check
Many time install koha common but version no change.


Koha version: 	19.11.00.000
OS version ('uname -a'): 	Linux koha-desktop 4.15.0-72-generic #81~16.04.1-Ubuntu SMP Tue Nov 26 16:30:00 UTC 2019 i686
Perl interpreter: 	/usr/bin/perl
Perl version: 	5.022001
Perl @INC: 	/usr/share/koha/lib
/usr/share/koha/installer
/usr/share/koha/lib/installer
/etc/perl
/usr/local/lib/i386-linux-gnu/perl/5.22.1
/usr/local/share/perl/5.22.1
/usr/lib/i386-linux-gnu/perl5/5.22
/usr/share/perl5
/usr/lib/i386-linux-gnu/perl/5.22
/usr/share/perl/5.22
/usr/local/lib/site_perl
/usr/lib/i386-linux-gnu/perl-base
.
/var/lib/koha/library/plugins
MySQL version: 	mysql Ver 14.14 Distrib 5.7.28, for Linux (i686) using EditLine wrapper
Apache version: 	Server version: Apache/2.4.18 (Ubuntu)
PSGI: 	Plack (deployment)
Memcached: 	Servers: 127.0.0.1:11211 | Namespace: koha_library | Status: running. | Config read from: koha-conf.xml
Zebra version: 	Zebra 2.0.59 (C) 1994-2014, Index Data Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: c00bfddbf0f3608340d61298acc61dafb167f9b2 Using ICU
Date and time: 	12/31/2019 15:06
Time zone: 	Used: Asia/Kolkata | Config: Undefined | Environment (TZ): Undefined

(In reply to Govind Basedia from comment #12)
> Dear sir
> I am upgrade koha 19.11.00 to 19.11.01 but no upgrade your site.please check
> Many time install koha common but version no change.
> 

It's possible that the Debian packages have not been built yet - so actually your Koha version is still on 19.11.00 with the bug.

koha@koha-V520-15IKL:~$ sudo apt-get install koha-common
[sudo] password for koha: 
Reading package lists... Done
Building dependency tree       
Reading state information... Done
koha-common is already the newest version (19.11.00-1).
The following packages were automatically installed and are no longer required:
  libncursesw5 libtinfo5
Use 'sudo apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
koha@koha-V520-15IKL:~$

(In reply to Govind Basedia from comment #14)
> koha@koha-V520-15IKL:~$ sudo apt-get install koha-common
> [sudo] password for koha: 
> Reading package lists... Done
> Building dependency tree       
> Reading state information... Done
> koha-common is already the newest version (19.11.00-1).
> The following packages were automatically installed and are no longer
> required:
>   libncursesw5 libtinfo5
> Use 'sudo apt autoremove' to remove them.
> 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
> koha@koha-V520-15IKL:~$

There are no packages for .01 yet, please try again in a few days.