Summary: | Improve the display of our datepickers | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, caroline.cyr-la-rose, lucas, martin.renvoize, oleonard |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Circulation function: | |||
Bug Depends on: | 23956 | ||
Bug Blocks: | 24363 | ||
Attachments: |
Bug 24181: Make our datepicker inputs sexy
Bug 24181: Move the icon back into the input Bug 24181: Make our datepicker inputs sexy Bug 24181: Move the icon back into the input Bug 24181: Make our datepicker inputs sexy Bug 24181: Move the icon back into the input Bug 24181: Make our datepicker inputs sexy Bug 24181: Move the icon back into the input |
Description
Jonathan Druart
2019-12-05 15:27:33 UTC
Created attachment 96044 [details] [review] Bug 24181: Make our datepicker inputs sexy They are skinny and different from others. Not that a problem, I am too. But I do not think it is what they need. Test plan: Edit a patron and take a look at the input for "Date of birth" => Before this patch they are not looking great => After this patch they are beautiful Created attachment 96045 [details] [review] Bug 24181: Move the icon back into the input Before: https://snipboard.io/zOPV4F.jpg After: https://snipboard.io/U4xVrq.jpg Hey Jonathan, I applied this patch and ran yarn build, it looks sexy in Chrome but not in FF as the calendar icon is doubling up. FireFox: https://snipboard.io/jxb7z6.jpg Chrome: https://snipboard.io/R6bjuS.jpg Jonathan did you see Bug 23956? I do like the "After" screenshot. Created attachment 96143 [details] [review] Bug 24181: Make our datepicker inputs sexy They are skinny and different from others. Not that a problem, I am too. But I do not think it is what they need. Test plan: Edit a patron and take a look at the input for "Date of birth" => Before this patch they are not looking great => After this patch they are beautiful Created attachment 96144 [details] [review] Bug 24181: Move the icon back into the input (In reply to Lucas Gass from comment #4) > Hey Jonathan, > > I applied this patch and ran yarn build, it looks sexy in Chrome but not in > FF as the calendar icon is doubling up. > > > FireFox: https://snipboard.io/jxb7z6.jpg > Chrome: https://snipboard.io/R6bjuS.jpg Hi Lucas, I did not recreate, I am using Firefox. Maybe a cache issue? (In reply to Owen Leonard from comment #5) > Jonathan did you see Bug 23956? I do like the "After" screenshot. I did not! Rebased on top of it. Created attachment 96168 [details] [review] Bug 24181: Make our datepicker inputs sexy They are skinny and different from others. Not that a problem, I am too. But I do not think it is what they need. Test plan: Edit a patron and take a look at the input for "Date of birth" => Before this patch they are not looking great => After this patch they are beautiful Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 96169 [details] [review] Bug 24181: Move the icon back into the input Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Not sure if it was a caching issue or not, but when I applied both patches and ran yarn build everything looks great so I am signing off. Created attachment 96581 [details] [review] Bug 24181: Make our datepicker inputs sexy They are skinny and different from others. Not that a problem, I am too. But I do not think it is what they need. Test plan: Edit a patron and take a look at the input for "Date of birth" => Before this patch they are not looking great => After this patch they are beautiful Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 96582 [details] [review] Bug 24181: Move the icon back into the input Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 The calendar icon in additem looks weird... see bug #24363 I was going through all the datepickers and found one that is still thinner, in checkexpiration.pl Pushed to 19.11.x branch for 19.11.02 (In reply to Joy Nelson from comment #17) > Pushed to 19.11.x branch for 19.11.02 Hi Joy, there is a lot of issues with this one still - I think it's not fit for stable yet. Choosing to skip this enhancement in 19.05.x, no backport Reverted from 19.11.x branch until more fixes available. |