Summary: | Introduce `before_send_messages` hook | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Plugin architecture | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, kyle, lucas, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch adds a new `plugin hook` to allow pre-processing of the message queue prior to sending messages.
|
Version(s) released in: |
20.05.00, 19.11.06
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 28221, 28474 | ||
Attachments: |
Bug 24183: Add before_send_messages hook
Bug 24183: Add before_send_messages hook Bug 24183: (RM follow-up) Remove re-introduced UseKohaPlugins |
Description
Martin Renvoize (ashimema)
2019-12-05 17:41:58 UTC
Created attachment 96048 [details] [review] Bug 24183: Add before_send_messages hook This patch adds a simple hook to the process_message_queue cronjob to allow plugins to pre-process messages in the messaging queue before they are sent. Can you add a test plan for this? I'd forgotten I'd written this.. but it's still just as relevant now.. Good question on requiring a test plan. Short of writing a plugin that utilizes it I'm really not sure how one can test this :( Ill try to come up with something. Created attachment 102079 [details] [review] Bug 24183: Add before_send_messages hook This patch adds a simple hook to the process_message_queue cronjob to allow plugins to pre-process messages in the messaging queue before they are sent. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Trivial and safe plugin hook implementation following the existing standard paradigm. Passing QA directly. I am ok with this - little nudges work sometimes! Nice work everyone! Pushed to master for 20.05 Created attachment 103463 [details] [review] Bug 24183: (RM follow-up) Remove re-introduced UseKohaPlugins We removed UseKohaPlugins in bug 20415 but incidentally added a reference to it bug 24183. This patch corrects that error. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice work everyone! Pushed to master for 20.05 feature not backported to 19.11.x per request, backported to 19.11.x branch for 19.11.06 I've added documentation to https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks#Implemented_hooks - can you please check if it's correct? Perfect, thanks Katrin. New feature won't be backported to 19.05.x |