| Summary: | Add CodeMirror linting of JavaScript, CSS, HTML, and YAML system preferences | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, david, dcook, gmcharlt, jonathan.druart, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement adds CodeMirror plugins for linting system preferences that include JS, CSS, HTML, and YAML. When invalid data is entered in a linted CodeMirror editor an icon is displayed in the editor's "gutter." Hovering over the icon displays the error message.
|
Version(s) released in: |
20.05.00
|
| Circulation function: | |||
|
Description
Owen Leonard
2019-12-09 18:11:33 UTC
This patch is too large to attach to Bugzilla so I've put a remote branch here: https://gitlab.com/koha-dev/koha-dev/commits/bug-24193-codemirror-linting Alternatively, a patch for download: https://zivotdesign.com/download/bug-24193-codemirror-linting.patch Tested using ByWaterSolutions sandboxes. Everything works as per the test plan. (Not sure if this the correct way to sign-off remote patches.) Hi Owen, tried with the downloadable patch, but it does no longer apply. Can you please rebase and add David's sign-off? I've rebased the downloadable patch and the remote branch. koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt:[% Asset.css("lib/codemirror/codemirror.css") | $raw %]
Should not it be codemirror.min.css?
I thought we were going to move those pref to the "news"? (In reply to Jonathan Druart from comment #5) > Should not it be codemirror.min.css? Fixed. > I thought we were going to move those pref to the "news"? The HTML linting aspect will eventually be obsolete, but the JS, CSS, and YAML linting is still relevant. Hm, can't run the QA tools on this patch: An error occurred : Unmatched ) in regex; marked by <-- HERE in m/_\([(?<string>[^[]*) <-- HERE [\)/ at /home/vagrant/qa-test-tools/QohA/File/JS.pm line 29. @RM: can you please add missing sign-off lines? :) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |