| Summary: | t/Auth_with_shibboleth.t is failing randomly | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, hayleypelham, lucas, martin.renvoize |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.01, 19.05.06, 18.11.12
|
|
| Circulation function: | |||
| Bug Depends on: | 23042 | ||
| Bug Blocks: | 25551 | ||
| Attachments: | Bug 24199: (bug 23042 follow-up) Prevent t/Auth_with_shibboleth.t to fail randomly | ||
Created attachment 96138 [details] [review] Bug 24199: (bug 23042 follow-up) Prevent t/Auth_with_shibboleth.t to fail randomly CGI->url_param does not always return the parameters in the same order. Test plan: 0/ Recreate the random failure, does not apply the patch and run t/Auth_with_shibboleth.t several times. You will notice that it fails inconsistenly 1/ Apply the patch and confirm that it now passes 100% of the time Thanks Jonathan.. that's the fix I was literally just testing locally as an RM followup.. Passing QA Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.01 backported to 19.05.x for 19.05.06 Backported to 18.11.x for 18.11.12 |
# at t/Auth_with_shibboleth.t line 140. # got: 'https://testopac.com/Shibboleth.sso/Login?target=https://testopac.com/cgi-bin/koha/opac-user.pl%3Fparam%3D%22heh%E2%9D%A4%22%26language%3Den-GB' # expected: 'https://testopac.com/Shibboleth.sso/Login?target=https://testopac.com/cgi-bin/koha/opac-user.pl%3Flanguage%3Den-GB%26param%3D%22heh%E2%9D%A4%22' CGI->url_param does not always return the parameters in the same order.