Summary: | intranet_js plugin hook is after body end tag | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Templates | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, hayleypelham, lucas, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.00, 19.11.01, 19.05.07, 18.11.13
|
Circulation function: | |
Attachments: |
Bug 24230: fix intranet_js plugin hook before body end tag
Bug 24230: fix intranet_js plugin hook before body end tag Bug 24230: fix intranet_js plugin hook before body end tag |
Description
Fridolin Somers
2019-12-12 13:24:07 UTC
Created attachment 96236 [details] [review] Bug 24230: fix intranet_js plugin hook before body end tag The plugin hook intranet_js is after body tag in intranet-bottom.inc : </body> [% KohaPlugins.get_plugins_intranet_js | $raw %] </html> It must be before like in opac-bottom.inc Test plan : 1) Install a Koha plugin with intranet_js hook, like KitechenSink 2) Go to an intranet page 3) Look at source of the page to see plugin code is before body end tag Created attachment 96239 [details] [review] Bug 24230: fix intranet_js plugin hook before body end tag The plugin hook intranet_js is after body tag in intranet-bottom.inc : </body> [% KohaPlugins.get_plugins_intranet_js | $raw %] </html> It must be before like in opac-bottom.inc Test plan : 1) Install a Koha plugin with intranet_js hook, like KitechenSink 2) Go to an intranet page 3) Look at source of the page to see plugin code is before body end tag Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Created attachment 96244 [details] [review] Bug 24230: fix intranet_js plugin hook before body end tag The plugin hook intranet_js is after body tag in intranet-bottom.inc : </body> [% KohaPlugins.get_plugins_intranet_js | $raw %] </html> It must be before like in opac-bottom.inc Test plan : 1) Install a Koha plugin with intranet_js hook, like KitechenSink 2) Go to an intranet page 3) Look at source of the page to see plugin code is before body end tag Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.01 backported to 19.05.x for 19.05.07 Backported to 18.11.x for 18.11.13 |