| Summary: | SIP2 returns debarred comment twice in patron screen message AF field | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | SIP2 | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, colin.campbell, hayleypelham, jonathan.druart, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.05, 19.05.10
|
|
| Circulation function: | |||
| Attachments: |
Bug 24250: Do not duplicate debarred comment in patron screen message AF field
Bug 24250: Do not duplicate debarred comment in patron screen message AF field Bug 24250: Do not duplicate debarred comment in patron screen message AF field |
||
Created attachment 96360 [details] [review] Bug 24250: Do not duplicate debarred comment in patron screen message AF field Caused by commit bddfed75913a2302c19c00b00a6fe86538af6f9f Bug 19933: Remove patronflags - tricky ones Test plan: 1 - Setup SIP in your testing environment https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2 - Set a patron to have a restriction 3 - Send a patron status request or patron information command via the SIP cli emulator (see link above) 4 - Note the comment on the restriction is sent only once Created attachment 100334 [details] [review] Bug 24250: Do not duplicate debarred comment in patron screen message AF field Caused by commit bddfed75913a2302c19c00b00a6fe86538af6f9f Bug 19933: Remove patronflags - tricky ones Test plan: 1 - Setup SIP in your testing environment https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2 - Set a patron to have a restriction 3 - Send a patron status request or patron information command via the SIP cli emulator (see link above) 4 - Note the comment on the restriction is sent only once Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as described.. Signing off Created attachment 101074 [details] [review] Bug 24250: Do not duplicate debarred comment in patron screen message AF field Caused by commit bddfed75913a2302c19c00b00a6fe86538af6f9f Bug 19933: Remove patronflags - tricky ones Test plan: 1 - Setup SIP in your testing environment https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2 - Set a patron to have a restriction 3 - Send a patron status request or patron information command via the SIP cli emulator (see link above) 4 - Note the comment on the restriction is sent only once Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Nice work everyone! Pushed to master for 20.05 backported to 19.11.x for 19.11.05 backported to 19.05.x for 19.05.10 Minor/normal will not be backported to 18.11.x series |
To recreate: 1 - Setup SIP in your testing environment https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2 - Set a patron to have a restriction 3 - Send a patron status request or patron information command via the SIP cli emulator (see link above) 4 - Note the comment on the restriction is sent twice