Bug 24268

Summary: advance_notices.pl dies on undefined letter
Product: Koha Reporter: Nick Clemens <nick>
Component: NoticesAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: 1joynelson, danielle, jonathan.druart, kyle, liz, lucas, martin.renvoize
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00, 19.11.01
Bug Depends on: 20478    
Bug Blocks:    
Attachments: Bug 24268: Break assignment and warn into separate actions
Bug 24268: Unit tests
Bug 24268: Break assignment and warn into separate actions
Bug 24268: Unit tests
Bug 24268: Unit tests
Bug 24268: Break assignment and warn into separate actions

Description Nick Clemens 2019-12-18 18:52:31 UTC
Bug 20478 changed the assignment/warn in advance_notices - it seems that new we either assign a letter, or the value of the warn (1) to the letter. This causes:

Can't use string ("1") as a HASH ref while "strict refs" in use at advance_notices.pl line 589.
Comment 1 Nick Clemens 2019-12-18 18:53:35 UTC
Created attachment 96458 [details] [review]
Bug 24268: Break assignment and warn into separate actions
Comment 2 Nick Clemens 2019-12-18 18:55:34 UTC
This should probably be covered by tests, shoudl be able to recreate the situation by having a patron request messages in a transport not defined in a digest message
Comment 3 Nick Clemens 2019-12-18 19:02:44 UTC
Created attachment 96459 [details] [review]
Bug 24268: Unit tests
Comment 4 Liz Rea 2019-12-18 20:22:47 UTC
Created attachment 96462 [details] [review]
Bug 24268: Break assignment and warn into separate actions

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment 5 Liz Rea 2019-12-18 20:22:58 UTC
Created attachment 96463 [details] [review]
Bug 24268: Unit tests

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment 6 Jonathan Druart 2019-12-19 06:57:44 UTC
Created attachment 96476 [details] [review]
Bug 24268: Unit tests

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2019-12-19 06:57:47 UTC
Created attachment 96477 [details] [review]
Bug 24268: Break assignment and warn into separate actions

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Martin Renvoize 2019-12-20 12:10:04 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 9 Joy Nelson 2019-12-20 18:57:40 UTC
Pushed to 19.11.01
Comment 10 Lucas Gass 2019-12-20 19:16:37 UTC
backported to 19.05.x for 19.05.06