Description
Martin Renvoize (ashimema)
2019-12-23 09:36:09 UTC
Created attachment 97433 [details] [review] Bug 24296: Update stockrotation process to use branchtransfers.trigger This patch updates all occurences of stockrotation related lookups of branchtransfers status from using the 'comments' field to using the new 'trigger' field. Test plan: 1) Work through the process of creating a stock rotation plan and adding items to the plan.. no errors should be encoutered during this process. 2) Run the stockrotation cronjob to move some items on.. no errors should be encountered. 3) Navigate to the transferstosend page in the circulation area of the staff client.. no errors should be encountered. Created attachment 97434 [details] [review] Bug 24296: Update existing data in the database This DB udpate adds the stockration states to the trigger enum in the branchtransfers table and then populates it with any such data currently contained within the comments field. Created attachment 97504 [details] [review] Bug 24296: Update existing data in the database This DB udpate adds the stockration states to the trigger enum in the branchtransfers table and then populates it with any such data currently contained within the comments field. https://bugs.koha-community.org/show_bug.cgi?id=24292 Created attachment 97505 [details] [review] Bug 24296: Update stockrotation process to use branchtransfers.trigger This patch updates all occurences of stockrotation related lookups of branchtransfers status from using the 'comments' field to using the new 'trigger' field. Test plan: 1) Work through the process of creating a stock rotation plan and adding items to the plan.. no errors should be encoutered during this process. 2) Run the stockrotation cronjob to move some items on.. no errors should be encountered. https://bugs.koha-community.org/show_bug.cgi?id=24292 Created attachment 97517 [details] [review] Bug 24296: Update existing data in the database This DB udpate adds the stockration states to the trigger enum in the branchtransfers table and then populates it with any such data currently contained within the comments field. https://bugs.koha-community.org/show_bug.cgi?id=24292 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 97518 [details] [review] Bug 24296: Update stockrotation process to use branchtransfers.trigger This patch updates all occurences of stockrotation related lookups of branchtransfers status from using the 'comments' field to using the new 'trigger' field. Test plan: 1) Work through the process of creating a stock rotation plan and adding items to the plan.. no errors should be encoutered during this process. 2) Run the stockrotation cronjob to move some items on.. no errors should be encountered. https://bugs.koha-community.org/show_bug.cgi?id=24292 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 97533 [details] [review] Bug 24296: Update existing data in the database This DB udpate adds the stockration states to the trigger enum in the branchtransfers table and then populates it with any such data currently contained within the comments field. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 97534 [details] [review] Bug 24296: Update stockrotation process to use branchtransfers.reason This patch updates all occurences of stockrotation related lookups of branchtransfers status from using the 'comments' field to using the new 'reason' field. Test plan: 1) Work through the process of creating a stock rotation plan and adding items to the plan.. no errors should be encoutered during this process. 2) Run the stockrotation cronjob to move some items on.. no errors should be encountered. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> CONFLICT (content): Merge conflict in t/db_dependent/StockRotationItems.t CONFLICT (content): Merge conflict in Koha/StockRotationItem.pm (In reply to Jonathan Druart from comment #9) > CONFLICT (content): Merge conflict in t/db_dependent/StockRotationItems.t > CONFLICT (content): Merge conflict in Koha/StockRotationItem.pm Forget that, a previous patch was not obsoleted. Created attachment 98024 [details] [review] Bug 24296: Update existing data in the database This DB udpate adds the stockration states to the trigger enum in the branchtransfers table and then populates it with any such data currently contained within the comments field. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 98025 [details] [review] Bug 24296: Update stockrotation process to use branchtransfers.reason This patch updates all occurences of stockrotation related lookups of branchtransfers status from using the 'comments' field to using the new 'reason' field. Test plan: 1) Work through the process of creating a stock rotation plan and adding items to the plan.. no errors should be encoutered during this process. 2) Run the stockrotation cronjob to move some items on.. no errors should be encountered. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |