Bug 24314

Created attachment 96671 [details] [review]
Bug 24314: Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019)

This updates the MARC framework files in the de-DE (German) installer
to the latest MARC standard. The files also include some translation
changes and fixes.

Files have been generated using the po files on translate.koha-community.org.

To test:
- Run the de-DE installer on a fresh database
- Verify that all files are installed without errors
- Verify that the frameworks are correctly in place

Hi Katrin,
trying a fresh install, some messages but not related with this patch

auth_val.sql
[Sun Dec 29 16:56:43 2019] install.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`authorised_values`, CONSTRAINT `authorised_values_authorised_values_category` FOREIGN KEY (`category`) REFERENCES `authorised_value_categories` (`category_name`) ON DELETE CASCADE ON U) at /usr/share/perl5/DBIx/RunSQL.pm line 273.


sample_patrons.sql
[Sun Dec 29 16:56:49 2019] install.pl: DBD::mysql::st execute failed: Unknown column 'guarantorid' in 'field list' at /usr/share/perl5/DBIx/RunSQL.pm line 273.

Have you seen this messages?
I did an update/install on de-DE files, then german install over a clean database.

Patch is good, all marc21 files load without problem.

Created attachment 96676 [details] [review]
Bug 24314: Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019)

This updates the MARC framework files in the de-DE (German) installer
to the latest MARC standard. The files also include some translation
changes and fixes.

Files have been generated using the po files on translate.koha-community.org.

To test:
- Run the de-DE installer on a fresh database
- Verify that all files are installed without errors
- Verify that the frameworks are correctly in place

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
MARC21 files load without problems, no qa errors.
Loaded into 'en' install (delete fw then load) all frameworks look good.

(In reply to Bernardo Gonzalez Kriegel from comment #2)
> Hi Katrin,
> trying a fresh install, some messages but not related with this patch
> 
> auth_val.sql
> [Sun Dec 29 16:56:43 2019] install.pl: DBD::mysql::st execute failed: Cannot
> add or update a child row: a foreign key constraint fails
> (`koha`.`authorised_values`, CONSTRAINT
> `authorised_values_authorised_values_category` FOREIGN KEY (`category`)
> REFERENCES `authorised_value_categories` (`category_name`) ON DELETE CASCADE
> ON U) at /usr/share/perl5/DBIx/RunSQL.pm line 273.
> 
> 
> sample_patrons.sql
> [Sun Dec 29 16:56:49 2019] install.pl: DBD::mysql::st execute failed:
> Unknown column 'guarantorid' in 'field list' at
> /usr/share/perl5/DBIx/RunSQL.pm line 273.
> 
> Have you seen this messages?
> I did an update/install on de-DE files, then german install over a clean
> database.
> 
> Patch is good, all marc21 files load without problem.

Thx Bernardo! Fixing the first with bug 24316, looking into the patrons next.

... and filed bug 24317 for the problem with the sample patrons. :(

authorities_normal_marc21.sql - Still getting
DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_kohadev`.`auth_subfield_structure`.`linkid` at row 34 at /usr/share/perl5/DBIx/RunSQL.pm line 273. 

But not related to this patch.

Created attachment 96734 [details] [review]
Bug 24314: Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019)

This updates the MARC framework files in the de-DE (German) installer
to the latest MARC standard. The files also include some translation
changes and fixes.

Files have been generated using the po files on translate.koha-community.org.

To test:
- Run the de-DE installer on a fresh database
- Verify that all files are installed without errors
- Verify that the frameworks are correctly in place

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
MARC21 files load without problems, no qa errors.
Loaded into 'en' install (delete fw then load) all frameworks look good.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

(In reply to Jonathan Druart from comment #6)
> authorities_normal_marc21.sql - Still getting
> DBD::mysql::st execute failed: Incorrect integer value: '' for column
> `koha_kohadev`.`auth_subfield_structure`.`linkid` at row 34 at
> /usr/share/perl5/DBIx/RunSQL.pm line 273. 
> 
> But not related to this patch.

See bug 24328.

Waiting on PQA on bug 24312

Nice work everyone!

Pushed to master for 20.05

Pushed to 19.11.x branch for 19.11.02

backported to 19.05.x for 19.05.07

Enhancement will not be backported to 18.11.x series.