Bug 24322

Created attachment 96701 [details] [review]
Bug 24322 - National Library of Medicine (NLM) call number to XSLT Detail

Please include a test plan for this.

Also, format the commit title with "Bug 24322: XXX" instead of "Bug 24322 - XXX"

Also spotted a small thing, it should have its own class:
+        <span class="results_summary ddc">

Created attachment 96973 [details] [review]
Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail

Thank you Joonas and Katrin for your excellent discoveries.

You didn't add the test plan still – you really should because 1) you will likely get more people signing off this because they don't need to delve into the code to check what this thing does and what is the feature (though a bit more verbose commit message would help also with this) 2) it gives a baseline for what things to test and others can do in addition other types of testing than what is just mentioned in the test plan.

TEST PLAN:

1. Find a bib record
2. Add MARC21 field 060
3. Show the bib via the bib detail page (detail.pl)
4. Observe the field 060 as NLM next to the other call numbers for this bib.

Tried to test this on the Bywater Solutions sandboxes but despite it appearing to apply the patch I can't see any NLM output in the Normal view on cgi-bin/koha/catalogue/detail.pl after making a new dummy MARC record and adding a 060 field. This is even though can see LOC and DDC output (050 and 082) in the same output.

Patch no longer applies:

Applying: Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl).
error: could not build fake ancestor
Patch failed at 0001 Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-24322-National-Library-of-Medicine-NLM-call-nu-kgmgi2.patch

(In reply to Jon Knight from comment #8)
> Tried to test this on the Bywater Solutions sandboxes but despite it
> appearing to apply the patch I can't see any NLM output in the Normal view
> on cgi-bin/koha/catalogue/detail.pl after making a new dummy MARC record and
> adding a 060 field. This is even though can see LOC and DDC output (050 and
> 082) in the same output.

Hi Jon.

That would be because the patch wasn't actually applied.

The way to tell it hasn't applied in ByWater's sandboxes:

1) Go to Logs > Koha Git log. The commit for the patch(es) with the bug number you are testing should show at the top of the page, e.g. Bug 24322: National....

2) Create a sandbox without putting a bug number in the 'Bug number' field. You will then get the current master branch for Koha. Then go to Actions > Apply patches. It will then show you what it has done and that the patch failed.

Have to admit that it's not very obvious to identify that the patch didn't apply!

David

Created attachment 110025 [details] [review]
Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail

This adds MARC21 060 - National Library of Medicine Call Number
https://www.loc.gov/marc/bibliographic/bd060.html

To test:
- Catalog records using the 060, examples can be found in the
  LOC documentation.
- Verify that the field displays on the detail pages in staff
  and OPAC

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
RRescued this patch by redoing the changes. Only change made
was moving the section up before "Other classification".

Created attachment 110096 [details] [review]
Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail

This adds MARC21 060 - National Library of Medicine Call Number
https://www.loc.gov/marc/bibliographic/bd060.html

To test:
- Catalog records using the 060, examples can be found in the
  LOC documentation.
- Verify that the field displays on the detail pages in staff
  and OPAC

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
RRescued this patch by redoing the changes. Only change made
was moving the section up before "Other classification".

Signed-off-by: David Nind <david@davidnind.com>

Taking the chance to count myself as QA here after David's sign-off.

Created attachment 110982 [details] [review]
Bug 24322: Simplify condition to separate elements

Pushed to master for 20.11, thanks to everybody involved!

enhancement will not be backported to 20.05.x