Summary: | AutoSelfCheckPass needs to be masked | ||
---|---|---|---|
Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
Component: | Authentication | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, dpavlin, fridolin.somers, hayleypelham, jonathan.druart, lucas, m.de.rooy, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.03, 19.05.08, 18.11.14
|
|
Circulation function: | |||
Attachments: |
Bug 24333: Add password class to AutoSelfCheck syspref
Password not masked Bug 24333: Add password class to AutoSelfCheck syspref Bug 24333: Add password class to AutoSelfCheck syspref |
Description
Christopher Brannon
2020-01-02 16:34:18 UTC
Created attachment 97072 [details] [review] Bug 24333: Add password class to AutoSelfCheck syspref To test: 1 - Go to Administration 2 - Search sysprefs for AutoSelfCheck 3 - Enter something into AutoSelfCheckPass 4 - Note it is not masked 5 - Apply patch 6 - Reload page 7 - Note password is now masked Nick, I have this loaded in a Bywater sandbox (24333) and there is no change. I've tried other browsers, and restarting the services. Nothing works. Work ok for me on Firefox 72.0.1 https://snipboard.io/n0WIu7.jpg Please try again. (In reply to Jonathan Druart from comment #3) > Work ok for me on Firefox 72.0.1 > https://snipboard.io/n0WIu7.jpg > > Please try again. Still not working on preferences.pl?tab=circulation for AutoSelfCheckPass in sandbox. And I can't get your screenshot to load. Created attachment 97327 [details]
Password not masked
Chris and Jonathan, This patch works for me on master. I applied, restart_all, cleared browser cache and it works in both Chrome and FF. Created attachment 97333 [details] [review] Bug 24333: Add password class to AutoSelfCheck syspref To test: 1 - Go to Administration 2 - Search sysprefs for AutoSelfCheck 3 - Enter something into AutoSelfCheckPass 4 - Note it is not masked 5 - Apply patch 6 - Reload page 7 - Note password is now masked Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> (In reply to Christopher Brannon from comment #4) > (In reply to Jonathan Druart from comment #3) > > Work ok for me on Firefox 72.0.1 > > https://snipboard.io/n0WIu7.jpg > > > > Please try again. > > Still not working on preferences.pl?tab=circulation for AutoSelfCheckPass in > sandbox. > > And I can't get your screenshot to load. Which browser did you try? Which sandbox? Created attachment 97477 [details] [review] Bug 24333: Add password class to AutoSelfCheck syspref To test: 1 - Go to Administration 2 - Search sysprefs for AutoSelfCheck 3 - Enter something into AutoSelfCheckPass 4 - Note it is not masked 5 - Apply patch 6 - Reload page 7 - Note password is now masked Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Works fine for me on FF, Chrome and Edge. Note that this class:password is already in use for enhanced_content too. Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 backported to 19.05.x for 19.05.08 Backported to 18.11.x for 18.11.14 |