| Summary: | Ask for confirmation before deleting a suggestion in the OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, maryse.simard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12937 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 24341 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC
Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC |
||
|
Description
Owen Leonard
2020-01-03 14:33:13 UTC
Created attachment 96798 [details] [review] Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC This patch modifies the OPAC suggestions interface so that patrons will be asked for confirmation before deleting suggestions. The patch also makes some minor markup changes to improve consistency between this interface and others in the OPAC. To test, apply the patch and log in to the OPAC as a user who has submitted multiple suggestions. - From the list of your suggestions, confirm that the "New purchase suggestion" and "Delete" links have Font Awesome icons. - Check the checkbox corresponding to one of your suggestions. You can also now click the title of the suggestions to control the checkbox. - When you check a box the "Delete" link at the top of the page should activate. - Clicking the delete link should trigger a confirmation modal showing the title(s) you selected. - The message and button labels should reflect whether one or multiple titles are being deleted. - Test that the confirm and cancel controls work correctly. - Also test this process via the delete button at the bottom of the table of suggestions. When selecting multiple titles to delete, the modal shows only [object Object] in it's body instead of the list of titles. The rest works perfectly. Created attachment 96809 [details] [review] Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC This patch modifies the OPAC suggestions interface so that patrons will be asked for confirmation before deleting suggestions. The patch also makes some minor markup changes to improve consistency between this interface and others in the OPAC. To test, apply the patch and log in to the OPAC as a user who has submitted multiple suggestions. - From the list of your suggestions, confirm that the "New purchase suggestion" and "Delete" links have Font Awesome icons. - Check the checkbox corresponding to one of your suggestions. You can also now click the title of the suggestions to control the checkbox. - When you check a box the "Delete" link at the top of the page should activate. - Clicking the delete link should trigger a confirmation modal showing the title(s) you selected. - The message and button labels should reflect whether one or multiple titles are being deleted. - Test that the confirm and cancel controls work correctly. - Also test this process via the delete button at the bottom of the table of suggestions. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Sorry, I forgot to apply the dependency. Everything works well. We'll need a sign-off on the dependency bug - Maryse, as you have tested both together, could you have a look? I was sure I had signed the dependency while testing... sorry for that. I just did now. (In reply to Maryse Simard from comment #6) > I was sure I had signed the dependency while testing... sorry for that. I > just did now. Great, thank you! Created attachment 97649 [details] [review] Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC This patch modifies the OPAC suggestions interface so that patrons will be asked for confirmation before deleting suggestions. The patch also makes some minor markup changes to improve consistency between this interface and others in the OPAC. To test, apply the patch and log in to the OPAC as a user who has submitted multiple suggestions. - From the list of your suggestions, confirm that the "New purchase suggestion" and "Delete" links have Font Awesome icons. - Check the checkbox corresponding to one of your suggestions. You can also now click the title of the suggestions to control the checkbox. - When you check a box the "Delete" link at the top of the page should activate. - Clicking the delete link should trigger a confirmation modal showing the title(s) you selected. - The message and button labels should reflect whether one or multiple titles are being deleted. - Test that the confirm and cancel controls work correctly. - Also test this process via the delete button at the bottom of the table of suggestions. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Enhancement not backported to 19.11.x |