| Summary: | Remove unimplemented upcoming events message | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Notices | Assignee: | Nicole C. Engard <nengard> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, jwagner, ztajoli |
| Version: | Main | ||
| Hardware: | PC | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 26985 | ||
| Attachments: |
patch
updated patch messaging on an indiv patron in staff messaging on an indiv patron in opac Screen shot of staff patron record editing message settings Screen shot of OPAC patron record editing message settings Screen shot of messaging settings in patron category setup follow up patch Screen shot after manual deletion of message transport entries |
||
|
Description
Chris Cormack
2010-05-21 00:51:08 UTC
Created attachment 2216 [details] [review] patch Created attachment 2222 [details] [review] updated patch Comment on attachment 2222 [details] [review] updated patch [11:14] <cait> nengard: around? [11:14] <nengard> yes [11:14] <cait> i saw you patch yesterday, but you were already gone. - can you perhaps delete the message option in gemran files too? [11:15] <nengard> oops - yup, sure can [11:15] <cait> not to speak about the other langauges, but would save me another database update :) [11:15] <cait> I think not many people thingk about the other languages :( I get a feeling it will get hard to keep them in sync [11:16] <cait> thanks a lot! [11:17] <nengard> i actually did check them with a previous patch (I forget which one) but something was different so i assumed they were always different ... [11:17] <nengard> anyway, this is no problem [11:18] <cait> some files aren't even translated and im not sure all languages really work for installation [11:18] <cait> German does :) [11:20] <cait> thx again! nengard++ [11:20] <nengard> np [11:28] <nengard> i remember why i stopped editing other languages now ... [11:28] <nengard> fatal: 0001-bug-2434-remove-upcoming-events-for-all-languages.patch: 112: patch contains a line longer than 998 characters [11:28] * braedon|home has quit (Quit: Leaving.) [11:28] <nengard> one of the files has a line that is too long ... off to hunt it down [11:32] <cait> oh [11:34] <nengard> oh crap i can't remove it ... it's a line i already edited so it's the line of the patch that is showing the line i removed .... okay emailing the patch as an attachment This bug is present also in 3.0.x version. In the linked mail there is the patch for italian version of notices.sql. The link is: http://lists.koha-community.org/pipermail/koha-patches/2010-June/012121.html Pushed patch removing the events message type. Please test and close. The line for Upcoming Events still is gone in patron category messaging setup, but still shows in staff mode on individual patron records, and in the OPAC My Messaging tab. Those need to be removed as well. It seems to be getting the line from C4/Form/MessagingPreferences.pm, which is looking at the message_transports table:
foreach my $transport ( @{$pref->{'transports'}} ) {
$option->{'transport-'.$transport} = 'checked="checked"';
}
$option->{'digest'} = 'checked="checked"' if $pref->{'wants_digest'};
}
$template->param(messaging_preferences => $messaging_options);
So does this mean that each site must remove that line from the transports table to get rid of it? Is this something that could be scripted as a patch?
On my 3.2 test server, as delivered there are two lines in that table that seem to be relevant:
message_attribute_id message_transport_type is_digest letter_module letter_code
3 email 0 circulation EVENT
3 sms 0 circulation EVENT
It looks like the EVENT notice file should also be removed.
I do not see that line in any of the pages you mentioned ... can you provide URLs and screenshots please? Created attachment 2282 [details]
messaging on an indiv patron in staff
Created attachment 2283 [details]
messaging on an indiv patron in opac
This does not show the event line anymore...
Comment on attachment 2282 [details]
messaging on an indiv patron in staff
This does not show the event line anymore...
Created attachment 2284 [details]
Screen shot of staff patron record editing message settings
This is from a 3.2 server updated to current head as of today.
Created attachment 2285 [details]
Screen shot of OPAC patron record editing message settings
This is from a 3.2 server updated to current head as of today.
Created attachment 2286 [details]
Screen shot of messaging settings in patron category setup
This is from a 3.2 server updated to current head as of today.
This is my transports table ... I don't have those rows you're seeing... mysql> select * from message_transports; +----------------------+------------------------+-----------+---------------+-------------+ | message_attribute_id | message_transport_type | is_digest | letter_module | letter_code | +----------------------+------------------------+-----------+---------------+-------------+ | 5 | email | 0 | circulation | CHECKIN | | 5 | sms | 0 | circulation | CHECKIN | | 6 | email | 0 | circulation | CHECKOUT | | 6 | sms | 0 | circulation | CHECKOUT | | 1 | email | 0 | circulation | DUE | | 1 | sms | 0 | circulation | DUE | | 1 | email | 1 | circulation | DUEDGST | | 1 | sms | 1 | circulation | DUEDGST | | 2 | email | 0 | circulation | PREDUE | | 2 | sms | 0 | circulation | PREDUE | | 2 | email | 1 | circulation | PREDUEDGST | | 2 | sms | 1 | circulation | PREDUEDGST | | 4 | email | 0 | reserves | HOLD | | 4 | sms | 0 | reserves | HOLD | +----------------------+------------------------+-----------+---------------+-------------+ 14 rows in set (0.00 sec) Created attachment 2287 [details]
follow up patch
This patch removes EVENT from the transports table for all languages
Pushed follow-up patch. Jane, can you test since it worked for me after my first patch? I updated my 3.2 test server, but I'm still seeing the Upcoming Events entries in my message transports table. The EVENT notice file is also still there. Per Nicole's request on the IRC, I ran the delete command from the update manually. It removed the entries from the transports table, but not from the display. See screen shot for current display. Created attachment 2311 [details]
Screen shot after manual deletion of message transport entries
I no longer see it on new installs or my upgrade ... does anyone else think this needs to remain open? For me (italian setup) this bug is not more present. It can be close |