Summary: | "Bibliographic record does not exist!" is not translatable | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | I18N/L10N | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, f.demians, lucas, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.02
|
|
Circulation function: | |||
Bug Depends on: | 21232 | ||
Bug Blocks: | |||
Attachments: |
Bug 24358: (bug 21232) Make the alert string translatable
Bug 24358: (bug 21232) Make the alert string translatable Bug 24358: (bug 21232) Make the alert string translatable |
Description
Jonathan Druart
2020-01-06 22:08:33 UTC
Created attachment 96866 [details] [review] Bug 24358: (bug 21232) Make the alert string translatable "Bibliographic record does not exist!" was not translatable as it was defined in the .js file Test plan: Repeat test plan from bug 21232 Bonus point: update and install a localized version and confirm that the message is translatable Created attachment 96868 [details] [review] Bug 24358: (bug 21232) Make the alert string translatable "Bibliographic record does not exist!" was not translatable as it was defined in the .js file Test plan: Repeat test plan from bug 21232 Bonus point: update and install a localized version and confirm that the message is translatable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 97185 [details] [review] Bug 24358: (bug 21232) Make the alert string translatable "Bibliographic record does not exist!" was not translatable as it was defined in the .js file Test plan: Repeat test plan from bug 21232 Bonus point: update and install a localized version and confirm that the message is translatable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.02 backported to 19.05.x for 19.05.07 (In reply to Lucas Gass from comment #6) > backported to 19.05.x for 19.05.07 Hi Lucas, there as no note on the dependency bug here for 19.05 - can you check? (In reply to Katrin Fischer from comment #7) > (In reply to Lucas Gass from comment #6) > > backported to 19.05.x for 19.05.07 > > Hi Lucas, there as no note on the dependency bug here for 19.05 - can you > check? Kait, sorry I forgot to update the bug. 21232 was backported to 19.05.x for 19.05.07. Thanks for checking. (In reply to Lucas Gass from comment #8) > (In reply to Katrin Fischer from comment #7) > > (In reply to Lucas Gass from comment #6) > > > backported to 19.05.x for 19.05.07 > > > > Hi Lucas, there as no note on the dependency bug here for 19.05 - can you > > check? > > Kait, sorry I forgot to update the bug. 21232 was backported to 19.05.x for > 19.05.07. > > > Thanks for checking. Great, thx! This bugfix has been reverted in 19.05.x and will NOT appear in that series. Sorry for the confusion. |