| Summary: | Using strict from TmplTokenizer.pm broke the translator script | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | I18N/L10N | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | 1joynelson, f.demians, martin.renvoize |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 24217 | ||
| Bug Blocks: | 25305 | ||
| Attachments: | Bug 24365: (bug 24217 follow-up) Fix encoding issue for translator script | ||
|
Description
Jonathan Druart
2020-01-07 14:50:36 UTC
Created attachment 96896 [details] [review] Bug 24365: (bug 24217 follow-up) Fix encoding issue for translator script I am not sure what happened here, but adding strict for TmplTokenizer.pm breaks a test for translation. It has been caught by a failing test: % prove xt/author/translatable-templates.t will display lines "invalid multibyte sequence" I did a diff between the generated files and found: < msgid "Ã rbok" --- > msgid "Årbok" Which made me think of an encoding issue. Specifying the encoding when write open the file fixes the problem. Test plan: % prove xt/author/translatable-templates.t must return green Trivial fix, PQA and Pushing Nice work everyone! Pushed to master for 20.05 not backported to 19.11.x |