Bug 24373

Summary: Correct basic cataloging editor CSS
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: 1joynelson, jonathan.druart, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00, 19.11.03
Bug Depends on: 23259    
Bug Blocks:    
Attachments: Bug 24373: Correct basic cataloging editor CSS
Bug 24373: Correct basic cataloging editor CSS
Bug 24373: Correct basic cataloging editor CSS
Bug 24373: Correct basic cataloging editor CSS

Description Owen Leonard 2020-01-07 19:48:28 UTC
Bug 23259 removed some low-level CSS which negatively affected the appearance of the basic cataloging editor. There shouldn't be green stripes around the tag/subfield tabs.
Comment 1 Owen Leonard 2020-01-07 19:56:22 UTC
Created attachment 96960 [details] [review]
Bug 24373: Correct basic cataloging editor CSS

This patch makes minor corrections to the basic MARC editor CSS, fixing
an error caused by Bug 23259.

To test, apply the patch and clear your browser cache if necessary.

Open the basic MARC editor and check the numbered tabs. There should be
no stripe of green background showing below the tabs.
Comment 2 Lucas Gass 2020-01-08 14:49:19 UTC
Created attachment 96997 [details] [review]
Bug 24373: Correct basic cataloging editor CSS

This patch makes minor corrections to the basic MARC editor CSS, fixing
an error caused by Bug 23259.

To test, apply the patch and clear your browser cache if necessary.

Open the basic MARC editor and check the numbered tabs. There should be
no stripe of green background showing below the tabs.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Guillaume Paquet 2020-01-08 15:18:50 UTC
Created attachment 97005 [details] [review]
Bug 24373: Correct basic cataloging editor CSS

This patch makes minor corrections to the basic MARC editor CSS, fixing
an error caused by Bug 23259.

To test, apply the patch and clear your browser cache if necessary.

Open the basic MARC editor and check the numbered tabs. There should be
no stripe of green background showing below the tabs.

Signed-off-by: Guillaume Paquet <guillaume@inlibro.com>
Comment 4 Jonathan Druart 2020-01-10 08:46:42 UTC
Before: https://snipboard.io/FA6Hh5.jpg
After:  https://snipboard.io/dL7Umq.jpg
Comment 5 Jonathan Druart 2020-01-10 08:47:56 UTC
Created attachment 97162 [details] [review]
Bug 24373: Correct basic cataloging editor CSS

This patch makes minor corrections to the basic MARC editor CSS, fixing
an error caused by Bug 23259.

To test, apply the patch and clear your browser cache if necessary.

Open the basic MARC editor and check the numbered tabs. There should be
no stripe of green background showing below the tabs.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Guillaume Paquet <guillaume@inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Martin Renvoize 2020-01-10 10:51:30 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 7 Joy Nelson 2020-01-31 21:31:21 UTC
Pushed to 19.11.x branch for 19.11.03