| Summary: | Useless test in acqui/lateorders.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | 1joynelson, black23, lucas |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.04, 19.05.09
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 24161 | ||
| Attachments: |
Bug 24388: Remove uneeded test in lateorders.tt
Bug 24388: Remove uneeded test in lateorders.tt Bug 24388: Remove uneeded test in lateorders.tt Bug 24388: Remove uneeded test in lateorders.tt |
||
Created attachment 97125 [details] [review] Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked Hi Jonathan, can you rebase this patch? sing index info to reconstruct a base tree... M t/db_dependent/Koha/Acquisition/Basket.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Acquisition/Basket.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Acquisition/Basket.t error: Failed to merge in the changes. Patch failed at 0001 Bug 24161: Add tests (In reply to Michal Denar from comment #2) > Hi Jonathan, > can you rebase this patch? > > sing index info to reconstruct a base tree... > M t/db_dependent/Koha/Acquisition/Basket.t > Falling back to patching base and 3-way merge... > Auto-merging t/db_dependent/Koha/Acquisition/Basket.t > CONFLICT (content): Merge conflict in > t/db_dependent/Koha/Acquisition/Basket.t > error: Failed to merge in the changes. > Patch failed at 0001 Bug 24161: Add tests This patch is at the top of a long dependency list. Created attachment 98690 [details] [review] Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked Created attachment 99117 [details] [review] Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors. Variable budget_lock is not set in acqui/lateorders.pl Created attachment 99131 [details] [review] Bug 24388: Remove uneeded test in lateorders.tt The budget_lock is never set (and has never been). Test plan: For QAer only, make sure this never worked Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors. Variable budget_lock is not set in acqui/lateorders.pl Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x for 19.11.04 backported to 19.05.x for 19.05.09 |
The budget_lock is never set (and has never been): [% UNLESS lateorder.budget_lock %] <input type="submit" class="btn btn-default" value="Claim order" /> [% END %]