| Summary: | Add item total to rotating collections (addItems.tt) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Tools | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, jzairo, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 24390: Add Item Total to Rotating collections
Bug 24390: Add Item Total to Rotating collections Bug 24390: Add item total to rotating collections Bug 24390: (QA follow-up) Fix capitalization and simplyfy code a bit |
||
|
Description
Lucas Gass (lukeg)
2020-01-09 17:06:03 UTC
Created attachment 97127 [details] [review] Bug 24390: Add Item Total to Rotating collections TEST PLAN: 1. Set up some rotating collections and add some items to them. 2. No good way to see how many total items are in a given collection. 3. Apply patch 4. Look at collections again and you should see 'Total Items: X' 5. Make sure it is counting the total number of items correctly. Created attachment 98994 [details] [review] Bug 24390: Add Item Total to Rotating collections Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Created attachment 99831 [details] [review] Bug 24390: Add item total to rotating collections Displays the number of items in a rotating collection. TEST PLAN: 1. Set up some rotating collections and add some items to them. 2. No good way to see how many total items are in a given collection. 3. Apply patch 4. Look at collections again and you should see 'Total Items: X' 5. Make sure it is counting the total number of items correctly. Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 99832 [details] [review] Bug 24390: (QA follow-up) Fix capitalization and simplyfy code a bit Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> @RM, please check proposed follow-up - leaving PQA as the change is quite small. @Lucas - please remember to add your test plans to the commit messages and also include a short description. Not entirely sure how the code worked before Katrins follow-up.. I like the follow-up, it seems much clearer to me. Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |