| Summary: | Remove event attributes from patron clubs edit template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, hayleypelham, lucas, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/clubs/templates-add-modify.pl | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.03, 19.05.08
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 18530 | ||
| Attachments: |
Bug 24391: Remove event attributes from patron clubs templates
Bug 24391: Remove event attributes from patron clubs edit template Bug 24391: Remove event attributes from patron clubs edit template Bug 24391: Remove event attributes from patron clubs edit template |
||
|
Description
Owen Leonard
2020-01-09 17:44:58 UTC
Created attachment 97128 [details] [review] Bug 24391: Remove event attributes from patron clubs templates This patch removes "onclick" attributes from the template for adding and editing patron club templates. To test, apply the patch and go to Tools -> Patron clubs -> New club template. Test the process of adding and deleting both club and enrollment fields. Test during the template add process and when editing an existing template. Created attachment 97140 [details] [review] Bug 24391: Remove event attributes from patron clubs edit template This patch removes "onclick" attributes from the template for adding and editing patron club templates. To test, apply the patch and go to Tools -> Patron clubs -> New club template. Test the process of adding and deleting both club and enrollment fields. Test during the template add process and when editing an existing template. Created attachment 97270 [details] [review] Bug 24391: Remove event attributes from patron clubs edit template This patch removes "onclick" attributes from the template for adding and editing patron club templates. To test, apply the patch and go to Tools -> Patron clubs -> New club template. Test the process of adding and deleting both club and enrollment fields. Test during the template add process and when editing an existing template. Signed-off-by: David Nind <david@davidnind.com> Hi Owen, is the dependency correct here? It looks like there were patches on bug 18530 once, but there aren't now. Created attachment 97373 [details] [review] Bug 24391: Remove event attributes from patron clubs edit template This patch removes "onclick" attributes from the template for adding and editing patron club templates. To test, apply the patch and go to Tools -> Patron clubs -> New club template. Test the process of adding and deleting both club and enrollment fields. Test during the template add process and when editing an existing template. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #4) > Hi Owen, is the dependency correct here? Sorry, it should block, not depend on, 18530 Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 backported to 19.05.x for 19.05.08 Enhancement will not be backported to 18.11.x series. |