Summary: | Floats in cash registers have 6 decimals | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | System Administration | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, gmcharlt, katrin.fischer, lucas, m.de.rooy, sally.healey |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.03
|
|
Attachments: |
Bug 24395: Show initial float using the Price TT plugin on summary page
Bug 24395: Show initial float using the Price TT plugin on summary page Bug 24395: Show initial float using the Price TT plugin on summary page Bug 24395: Show initial float using the Price TT plugin on summary page Bug 24395: Show initial float using the Price TT plugin on summary page |
Description
Caroline Cyr La Rose
2020-01-09 20:17:06 UTC
Probably should be using the TT Price template? Created attachment 97422 [details] [review] Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Note: This doesn't fix Created attachment 97423 [details] [review] Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Created attachment 97432 [details] [review] Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Enable the cash register feature (set UseCashRegisters to 'Use') - Go to More > Administration > Accounting > Cash registers - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Signed-off-by: David Nind <david@davidnind.com> Created attachment 97473 [details] [review] Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Thx Caroline and David! Created attachment 97474 [details] [review] Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 no cash_registers.tt in 19.05.x, not backporting |