Summary: | Some roles missing from about page | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | About | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | 1joynelson, jonathan.druart, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.05
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 18303 | ||
Attachments: |
Bug 24402: About template corrections
Screenshot of 19.11 Screenshot of 19.12 (20.05 Development Version) Bug 24402: About template corrections Bug 24402: About template corrections |
Description
Katrin Fischer
2020-01-11 11:41:36 UTC
Aha.. it's because their arrays as opposed to singles.. thanks. I'll take a look later today. Created attachment 100310 [details] [review] Bug 24402: About template corrections With the 20.05 team we introduced and expanded some roles. This patch adds support for: * removal of the release maintainer for development releases * a list of documentation managers * a list of packaging manager Created attachment 100311 [details]
Screenshot of 19.11
Created attachment 100312 [details]
Screenshot of 19.12 (20.05 Development Version)
This patch needs testing in both 19.11 and master as the resultant output is different between the two.. screenshots included to show results as I see them. The patch corrects the behaviour for documentation and packaging roles, which both change from a single field to an array with the creation of the 20.05 team. It also removes the 'Release maintainer' title from the 'Current team' block when we are 'in development' as at this stage there is not release maintainer for the branch (it's in development, so the responsibility lies with the release manager) Created attachment 100484 [details] [review] Bug 24402: About template corrections With the 20.05 team we introduced and expanded some roles. This patch adds support for: * removal of the release maintainer for development releases * a list of documentation managers * a list of packaging manager Signed-off-by: Michal Denar <black23@gmail.com> Why not "release manager" at the top? (In reply to Jonathan Druart from comment #8) > Why not "release manager" at the top? At the time when we first added the two column approach I felt the most important person on the 'Maintanence team' side was the current RMaint for the version you are running.. hence swapping the order of rmaints vs rms in the two teams.. that's much clearer in a 'stable' release than in the 'development' stage though.. Happy to change it if people feel there is a better order? (In reply to Martin Renvoize from comment #9) > (In reply to Jonathan Druart from comment #8) > > Why not "release manager" at the top? > > At the time when we first added the two column approach I felt the most > important person on the 'Maintanence team' side was the current RMaint for > the version you are running.. hence swapping the order of rmaints vs rms in > the two teams.. that's much clearer in a 'stable' release than in the > 'development' stage though.. > > Happy to change it if people feel there is a better order? First should be the one you blame if you face issues, so RM ;) Rmaint should stay first for stable, I agree. Created attachment 100699 [details] [review] Bug 24402: About template corrections With the 20.05 team we introduced and expanded some roles. This patch adds support for: * removal of the release maintainer for development releases * a list of documentation managers * a list of packaging manager Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> What about comment 10, Katrin? (In reply to Jonathan Druart from comment #12) > What about comment 10, Katrin? I think it feels like a separate issue to me - the order is not changed in this bug, if I see it correctly. I think having the maints on top makes sense to me. Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x branch for 19.11.05 |