Summary: | Add a span to patron category category type codes in patron search result lists | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Patrons | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, gmcharlt, kyle.m.hall, kyle, martin.renvoize, oleonard, sally.healey |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
The patron category type code (A, C, O, ...) is currently displayed in the patron module search, patron card creator, and acquisition patron searches.
This information is not useful for most users, as these are internal codes that cannot be easily "decoded". And while you might be able to guess A as Adult in English, it doesn't translate to other languages.
This patch wraps a span around the patron category type code shown in () after the patron category.
|
Version(s) released in: |
21.11.00
|
Circulation function: | |||
Attachments: |
Bug 24406: Wrap patron category type code in a span on patron search results
Bug 24406: Wrap patron category type code in a span on patron search results Bug 24406: Wrap patron category type code in a span on patron search results |
Description
Katrin Fischer
2020-01-12 11:54:34 UTC
Created attachment 124080 [details] [review] Bug 24406: Wrap patron category type code in a span on patron search results The patron category type code (A, C, O, ...) is currently displayed in the patron module search and the patron card creator and acquisition patron searches. This information is not useful for most users, as these are internal codes that cannot be easily "decoded". And while you might be able to guess A as Adult in English, it doesn't translate to other languages. This patch wraps a span around the patron category type code shown in () after the patron category. To test: - Verify for each of the following three searches, that the patron category code displays in the search results, but is wrapped in a span with the class patron_category_type - Tools > Patron card creator - New > New card batch > Add patrons - Search for patrons - Patrons - Search for patrons - Acquisitions - Add a budget - Add a fund for the budget - Search for a user or owner to add I think a span would be the easiest to agree to, but I don't really feel like it's the best possible solution. Owen or others, maybe you got a better idea? Created attachment 125989 [details] [review] Bug 24406: Wrap patron category type code in a span on patron search results The patron category type code (A, C, O, ...) is currently displayed in the patron module search and the patron card creator and acquisition patron searches. This information is not useful for most users, as these are internal codes that cannot be easily "decoded". And while you might be able to guess A as Adult in English, it doesn't translate to other languages. This patch wraps a span around the patron category type code shown in () after the patron category. To test: - Verify for each of the following three searches, that the patron category code displays in the search results, but is wrapped in a span with the class patron_category_type - Tools > Patron card creator - New > New card batch > Add patrons - Search for patrons - Patrons - Search for patrons - Acquisitions - Add a budget - Add a fund for the budget - Search for a user or owner to add Signed-off-by: David Nind <david@davidnind.com> (In reply to Katrin Fischer from comment #2) > I think a span would be the easiest to agree to, but I don't really feel > like it's the best possible solution. > > Owen or others, maybe you got a better idea? I've signed off as it is currently. Happy to sign off again if others have a better idea. Created attachment 127151 [details] [review] Bug 24406: Wrap patron category type code in a span on patron search results The patron category type code (A, C, O, ...) is currently displayed in the patron module search and the patron card creator and acquisition patron searches. This information is not useful for most users, as these are internal codes that cannot be easily "decoded". And while you might be able to guess A as Adult in English, it doesn't translate to other languages. This patch wraps a span around the patron category type code shown in () after the patron category. To test: - Verify for each of the following three searches, that the patron category code displays in the search results, but is wrapped in a span with the class patron_category_type - Tools > Patron card creator - New > New card batch > Add patrons - Search for patrons - Patrons - Search for patrons - Acquisitions - Add a budget - Add a fund for the budget - Search for a user or owner to add Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial patch that provides a suitable work around.. It would be nice to see another bug reported to do a nicer job of allowing conversion of these type codes to translatable descriptions. Passing QA Pushed to master for 21.11, thanks to everybody involved! |