Bug 24408

Summary: Comparing floats in tests should not care about precision
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: 1joynelson, martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00, 19.11.03
Bug Depends on: 24146    
Bug Blocks:    
Attachments: Bug 24408: Do not compare floats with precision in tests
Bug 24408: Do not compare floats with precision in tests

Description Jonathan Druart 2020-01-13 12:30:08 UTC
We should not compare floating precision in tests.
Comment 1 Jonathan Druart 2020-01-13 12:31:13 UTC
Created attachment 97308 [details] [review]
Bug 24408: Do not compare floats with precision in tests

We should not compare floating precision in tests.

Test plan:
Confirm that the tests still pass after this patch
Comment 2 Jonathan Druart 2020-01-13 12:35:44 UTC
Created attachment 97309 [details] [review]
Bug 24408: Do not compare floats with precision in tests

We should not compare floating precision in tests.

Test plan:
Confirm that the tests still pass after this patch
Comment 3 Jonathan Druart 2020-01-13 12:42:41 UTC
PR for QA script: https://gitlab.com/koha-community/qa-test-tools/commits/issue_21
Will be merged if this bugfix is accepted.
Comment 4 Martin Renvoize 2020-01-13 13:44:13 UTC
Fast passing QA.. a sensible fix and discussed with Jonathan.
Comment 5 Martin Renvoize 2020-01-13 13:45:00 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 6 Joy Nelson 2020-01-31 23:13:01 UTC
Pushed to 19.11.x branch for 19.11.03
Comment 7 Jonathan Druart 2020-02-03 13:56:06 UTC
(In reply to Jonathan Druart from comment #3)
> PR for QA script:
> https://gitlab.com/koha-community/qa-test-tools/commits/issue_21
> Will be merged if this bugfix is accepted.

Done!