| Summary: | Multi holds broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Hold requests | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | critical | ||
| Priority: | P5 - low | CC: | 1joynelson, agustinmoyano, gmcharlt, julian.maurice, lucas, martin.renvoize, nick, sally.healey, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24587 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.04
|
|
| Circulation function: | |||
| Bug Depends on: | 19618 | ||
| Bug Blocks: | 15261, 24599 | ||
| Attachments: |
Bug 24410: Fix multi holds
Bug 24410: Fix multi holds Bug 24410: Fix multi holds Bug 24410: Fix multi holds |
||
|
Description
Jonathan Druart
2020-01-13 13:29:30 UTC
Created attachment 97310 [details] [review] Bug 24410: Fix multi holds Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Test plan: Confirm that prior to this patch you are not able to place a hold on several records at once, and that this patch fixes it I tested the multi_hold flow and it calls request.pl or modrequest.pl (when you update the multi hold). I belive we are safe without this patch. This seems to work ok. Assigning to Tomas for the next steps (ie. more work is needed if placerequest can be removed). *** Bug 24571 has been marked as a duplicate of this bug. *** From Nick on bug 24571 """ In the staff client do a search that returns 20+ results that can be held Select all Place hold Confirm The api submits ~8 requests, then the page moves to the hold results, but not alll records are held While this does work in Chrome, there is no feedback as to what is happening - the submit button is not disabled. Testing with 200 holds there is a lot of waiting with no feedback """ (In reply to Jonathan Druart from comment #5) > From Nick on bug 24571 > > """ > In the staff client do a search that returns 20+ results that can be held > > Select all > > Place hold > > Confirm > > The api submits ~8 requests, then the page moves to the hold results, but > not alll records are held > > > While this does work in Chrome, there is no feedback as to what is happening > - the submit button is not disabled. Testing with 200 holds there is a lot > of waiting with no feedback > """ I'm thinking.. is there any RFC for bulk processing endpoints?.. maybe we can create an endpoint that does multiholds. What do You think Jonathan? *** Bug 24587 has been marked as a duplicate of this bug. *** Agustin, as this affect stable and that the bug is now confirmed I think we should move this patch forward ASAP then discuss later how we can use the endpoint for multi holds. Created attachment 98479 [details] [review] Bug 24410: Fix multi holds Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Test plan: Confirm that prior to this patch you are not able to place a hold on several records at once, and that this patch fixes it Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 98508 [details] [review] Bug 24410: Fix multi holds Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Test plan: Confirm that prior to this patch you are not able to place a hold on several records at once, and that this patch fixes it Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Created attachment 98517 [details] [review] Bug 24410: Fix multi holds Bug 19618 replaces the call to placerequest.pl with a REST API /holds That is wrong as it does not support multi holds. Test plan: Confirm that prior to this patch you are not able to place a hold on several records at once, and that this patch fixes it Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This is a simple partial revert to restore functionality.. Passing QA. Lets handle the final removal of those controllers and switch to REST apis as a separate issue. Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x for 19.11.04 missing dependencies for 19.05.x, no backport |