Summary: | Charges/Fees.t is failing randomly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Chris Cormack <chris> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25729 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 25551 |
Description
Jonathan Druart
2020-01-14 09:47:36 UTC
Let me know if something needs doing on 19.11.x branch. Same failure, Koha_19.05_U18 https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_U18/234/consoleText Was able to get a failure locally with koha-testing-docker with KOHA_IMAGE=19.05-stretch. Not sure if it's the same issue though. t/db_dependent/Koha/Charges/Fees.t .. 1/8 # Failed test 'from_date default set correctly to today' # at t/db_dependent/Koha/Charges/Fees.t line 199. # got: '2020-06-12T05:05:16' # expected: '2020-06-12T05:05:17' # Looks like you failed 1 test of 9. t/db_dependent/Koha/Charges/Fees.t .. 2/8 # Failed test 'new' # at t/db_dependent/Koha/Charges/Fees.t line 201. # Looks like you failed 1 test of 8. t/db_dependent/Koha/Charges/Fees.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests (after 3100 runs) (In reply to Victor Grousset/tuxayo from comment #3) > Was able to get a failure locally with koha-testing-docker with > KOHA_IMAGE=19.05-stretch. > Not sure if it's the same issue though. > > t/db_dependent/Koha/Charges/Fees.t .. 1/8 > # Failed test 'from_date default set correctly to today' > # at t/db_dependent/Koha/Charges/Fees.t line 199. > # got: '2020-06-12T05:05:16' > # expected: '2020-06-12T05:05:17' > # Looks like you failed 1 test of 9. > t/db_dependent/Koha/Charges/Fees.t .. 2/8 > # Failed test 'new' > # at t/db_dependent/Koha/Charges/Fees.t line 201. > # Looks like you failed 1 test of 8. > t/db_dependent/Koha/Charges/Fees.t .. Dubious, test returned 1 (wstat 256, > 0x100) > Failed 1/8 subtests This is something different. 201 is( $fees->from_date, dt_from_string(), 202 'from_date default set correctly to today' ); It can be fixed using t::lib::Dates::compare bug has been opened 25729 comments related to bug 25729 were marked as obsolete (In reply to Victor Grousset/tuxayo from comment #2) > Same failure, Koha_19.05_U18 > https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_U18/234/ > consoleText This is still valid even if I couldn't reproduce locally. koha_1 | # Failed test 'Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Thursday' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 362. koha_1 | # got: '6' koha_1 | # expected: '5' koha_1 | koha_1 | # Failed test 'Hourly rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Thursday (96h - 24h * 0.25u)' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 396. koha_1 | # got: '24' koha_1 | # expected: '18' koha_1 | # Looks like you failed 2 tests of 7. koha_1 | koha_1 | # Failed test 'accumulate_rentalcharge tests' koha_1 | # at t/db_dependent/Koha/Charges/Fees.t line 403. |