Summary: | Generated authorities are missing subfields | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens <nick> |
Component: | MARC Authority data support | Assignee: | Nick Clemens <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | 1joynelson, aspencatteam, gveranis, hayleypelham, jonathan.druart, lucas, mkstephens |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.03, 19.05.08
|
|
Bug Depends on: | 21826 | ||
Bug Blocks: | 24269 | ||
Attachments: |
Bug 24421: Check if subfields are valid using the biblio tag
Bug 24421: Check if subfields are valid using the biblio tag Bug 24421: Unit tests Bug 24421: Check if subfields are valid using the biblio tag Bug 24421: Unit tests Bug 24421: Check if subfields are valid using the biblio tag |
Description
Nick Clemens
2020-01-14 16:07:43 UTC
Created attachment 97358 [details] [review] Bug 24421: Check if subfields are valid using the biblio tag To test: 1 - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink 2 - Open a record with a subject heading with a subdivision and add a new subfield, or add a new unauthroized heading to a record and save it e.g. 650$aChess$xOpenings$vFiction. 3 - Save the record, note the created authority and that field is linked 4 - Save the record again and note the authority number changes 5 - Find and view the authority linked to the record 6 - The record is for 'Chess', not Chess openings' 7 - Search authorities for 'Chess' - note duplicated records 8 - Apply patch, restart all 9 - Save the record, auth number increases again, we shoudl create the correct record this time 10 - Save again, auth number should not change 11 - Search authorities and confirm the generated authority has the correct subfields In certain instances this can cause nearly the entire catalog to be relinked to new authorities and generate many duplicated records - marking as critical Created attachment 97583 [details] [review] Bug 24421: Check if subfields are valid using the biblio tag To test: 1 - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink 2 - Open a record with a subject heading with a subdivision and add a new subfield, or add a new unauthroized heading to a record and save it e.g. 650$aChess$xOpenings$vFiction. 3 - Save the record, note the created authority and that field is linked 4 - Save the record again and note the authority number changes 5 - Find and view the authority linked to the record 6 - The record is for 'Chess', not Chess openings' 7 - Search authorities for 'Chess' - note duplicated records 8 - Apply patch, restart all 9 - Save the record, auth number increases again, we shoudl create the correct record this time 10 - Save again, auth number should not change 11 - Search authorities and confirm the generated authority has the correct subfields Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Patch works as expected. Thank you! Nick, can you cover the change with tests please? Created attachment 97881 [details] [review] Bug 24421: Unit tests Created attachment 97882 [details] [review] Bug 24421: Check if subfields are valid using the biblio tag To test: 1 - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink 2 - Open a record with a subject heading with a subdivision and add a new subfield, or add a new unauthroized heading to a record and save it e.g. 650$aChess$xOpenings$vFiction. 3 - Save the record, note the created authority and that field is linked 4 - Save the record again and note the authority number changes 5 - Find and view the authority linked to the record 6 - The record is for 'Chess', not Chess openings' 7 - Search authorities for 'Chess' - note duplicated records 8 - Apply patch, restart all 9 - Save the record, auth number increases again, we shoudl create the correct record this time 10 - Save again, auth number should not change 11 - Search authorities and confirm the generated authority has the correct subfields Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Coming from commit b2b7d376d4854394322310f28d2f5aa1560384e0 Bug 21826: Use subfield map in LinkBibHeadingsToAuthorities Created attachment 97968 [details] [review] Bug 24421: Unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 97969 [details] [review] Bug 24421: Check if subfields are valid using the biblio tag To test: 1 - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink 2 - Open a record with a subject heading with a subdivision and add a new subfield, or add a new unauthroized heading to a record and save it e.g. 650$aChess$xOpenings$vFiction. 3 - Save the record, note the created authority and that field is linked 4 - Save the record again and note the authority number changes 5 - Find and view the authority linked to the record 6 - The record is for 'Chess', not Chess openings' 7 - Search authorities for 'Chess' - note duplicated records 8 - Apply patch, restart all 9 - Save the record, auth number increases again, we shoudl create the correct record this time 10 - Save again, auth number should not change 11 - Search authorities and confirm the generated authority has the correct subfields Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 backported to 19.05.x for 19.05.08 Depends on code not in 18.11.x, not backporting *** Bug 23532 has been marked as a duplicate of this bug. *** |