Bug 24445

Summary: Add missing Z3950 updates to Makefile.PL
Product: Koha Reporter: Mason James <mtj>
Component: Installation and upgrade (command-line installer)Assignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: critical    
Priority: P1 - high CC: 1joynelson, lucas, martin.renvoize, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00, 19.11.02
Circulation function:
Bug Depends on: 13937    
Bug Blocks:    
Attachments: Bug 13937: add z3950 to makefile
Add missing Z3950 updates to Makefile.PL, so tar file will build ok
Bug 24445: Add z3950 to makefile (bug 13937 follow-up)

Description Mason James 2020-01-17 10:48:44 UTC
Add missing Z3950 updates to Makefile.PL, so tar file will build ok

this bug was introduced in BZ 13937


to test...
 1/ attempt to build koha tar, observe failure
 2/ apply patch 
 3/ attempt to build koha tar, observe success!
Comment 1 Mason James 2020-01-17 10:50:55 UTC
Created attachment 97494 [details] [review]
Bug 13937: add z3950 to makefile
Comment 2 Mason James 2020-01-17 10:55:45 UTC
Created attachment 97495 [details] [review]
Add missing Z3950 updates to Makefile.PL, so tar file will build ok

this bug was introduced in BZ 13937


to test...
 1/ attempt to build koha tar, observe failure
 2/ apply patch 
 3/ attempt to build koha tar, observe success!
Comment 3 Mason James 2020-01-17 11:05:51 UTC
(In reply to Mason James from comment #2)
> Created attachment 97495 [details] [review] [review]
> Add missing Z3950 updates to Makefile.PL, so tar file will build ok
> 
> this bug was introduced in BZ 13937

hi Joy, needs to be backported to 19.11.x branch too :0)
Comment 4 Martin Renvoize (ashimema) 2020-01-17 11:09:07 UTC
Created attachment 97497 [details] [review]
Bug 24445: Add z3950 to makefile (bug 13937 follow-up)

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2020-01-17 11:10:28 UTC
Trivial correction, Passing QA.. Thanks Mason
Comment 6 Martin Renvoize (ashimema) 2020-01-17 11:12:43 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 7 Joy Nelson 2020-01-18 14:50:37 UTC
Pushed to 19.11.x branch for 19.11.02
Comment 8 Lucas Gass (lukeg) 2020-02-05 20:45:00 UTC
19.05.x lacks dependency, no backport