| Summary: | POD of C4::Members::Messaging::GetMessagingPreferences() is misleading | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | Notices | Assignee: | Eden <eden.bacani> |
| Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew, caroline.cyr-la-rose, eden.bacani, fridolin.somers, jamespfk, kyle, victor |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.03,20.05.09,19.11.15
|
|
| Circulation function: | |||
| Attachments: |
Bug 24447: Changing 'DUE' to example in database that exists.
Bug 24447: Changing 'DUE' to example in database that exists. Bug 24447: Changing 'DUE' to example in database that exists. |
||
Created attachment 115484 [details] [review] Bug 24447: Changing 'DUE' to example in database that exists. Test Plan: 1.Using perldoc C4/Members/Messaging.pm check that message_name attribute name example is Item_Due and not DUE. Created attachment 115603 [details] [review] Bug 24447: Changing 'DUE' to example in database that exists. Test Plan: 1.Using perldoc C4/Members/Messaging.pm check that message_name attribute name example is Item_Due and not DUE. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice one, thx Eden! Created attachment 115606 [details] [review] Bug 24447: Changing 'DUE' to example in database that exists. Test Plan: 1.Using perldoc C4/Members/Messaging.pm check that message_name attribute name example is Item_Due and not DUE. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.03 Pushed to 20.05.x for 20.05.09 Backported: Pushed to 19.11.x branch for 19.11.15 |
Part of the POD for this subroutine looks like this: 42 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $borrower->{'borrowernumber'}, 43 message_name => 'DUE' } ); 44 45 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { categorycode => 'LIBRARY', 46 message_name => 'DUE' } ); It looks like the value for message_name should be a value from letter.code, but it should be a name from message_attributes.message_name: 75 AND message_transports.is_digest = borrower_message_preferences.wants_digest 76 WHERE message_attributes.message_name = ? 77 END_SQL 78 79 my @bind_params = ( $params->{'message_name'} ); Note: This subroutine is set to be renamed and moved by Bug 18595, but the POD seems to be untouched there.