| Summary: | previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder sort incorrectly | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, andrew, gmcharlt, hayleypelham, jonathan.druart, kelly, kyle.m.hall, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.05, 19.05.10
|
|
| Circulation function: | |||
| Bug Depends on: | 23427 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 24456: change default sort orders/make wording clearer
Bug 24456: change default sort orders/make wording clearer Bug 24456: change default sort orders/make wording clearer |
||
Created attachment 97580 [details] [review] Bug 24456: change default sort orders/make wording clearer TEST PLAN: 1. Apply patch 2. Have some checkout from today and some from multiple previous days. 3. Set todaysIssuesDefaultSortOrder & previousIssuesDefaultSortOrder to 'earliest to latest' and confirm it sorts correctly. 4. Reverse the 2 system preferences and see that it is now sorting the opposite way. 5. Also look at the wording of each system prefence and make sure it makes sense Created attachment 98103 [details] [review] Bug 24456: change default sort orders/make wording clearer Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 100911 [details] [review] Bug 24456: change default sort orders/make wording clearer TEST PLAN: 1. Apply patch 2. Have some checkout from today and some from multiple previous days. 3. Set todaysIssuesDefaultSortOrder & previousIssuesDefaultSortOrder to 'earliest to latest' and confirm it sorts correctly. 4. Reverse the 2 system preferences and see that it is now sorting the opposite way. 5. Also look at the wording of each system prefence and make sure it makes sense Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x for 19.11.05 backported to 19.05.x for 19.05.10 Dependency not in 18.11.x, will not be backporting to 18.11.x series |
previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder are backwards. If you choose 'earliest to latest' it sorts 'latest to earliest' and vise versa. Also the wording of todaysIssuesDefaultSortOrder is wrong. It says "Sort today's checkouts on the circulation page from {X} due date." With today's checkouts it does not sort by date due but by timestamp.