| Summary: | Overloaded ->to_api needs to pass $params through | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 18731 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 24459: Regression tests
Bug 24459: Make ->to_api pass $params through Bug 24459: Regression tests Bug 24459: Make ->to_api pass $params through |
||
|
Description
Tomás Cohen Arazi (tcohen)
2020-01-20 12:28:03 UTC
There are previously defined ->to_api methods in the Koha::* namespace that are missing parameters handling. See bug 24457 Created attachment 97621 [details] [review] Bug 24459: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 97622 [details] [review] Bug 24459: Make ->to_api pass $params through This patch makes the to_api method in Koha::Acquisition::Inovice and Koha::Patron pass the passed parameters to the base class to_api method. This is required for things like embedding related objects. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t \ t/db_dependent/Koha/Acquisition/Invoice.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 97674 [details] [review] Bug 24459: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 97675 [details] [review] Bug 24459: Make ->to_api pass $params through This patch makes the to_api method in Koha::Acquisition::Inovice and Koha::Patron pass the passed parameters to the base class to_api method. This is required for things like embedding related objects. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Patron.t \ t/db_dependent/Koha/Acquisition/Invoice.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 dependencies lacking in 19.11.x not backported |