Summary: | Syndetics content should be $raw filtered on opac-detail.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | OPAC | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, david, jduffels, jeremy.evans, jonathan.druart, stina.hallin, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
Syndetics provides enhanced content which is displayed in the OPAC under the tabs 'Title Notes', 'Excerpt', 'About the author', and 'Editions'. They provide this information as HTML but Koha currently displays the content with the HTML tags. This fixes this so that the enhanced content displays correctly.
|
|
Version(s) released in: |
20.11.00, 20.05.03, 19.11.09
|
Circulation function: | |
Attachments: |
Bug 24473: Add $raw filter for Syndetics content
Bug 24473: Add $raw filter for Syndetics content Bug 24473: Add $raw filter for Syndetics content |
Description
Lucas Gass (lukeg)
2020-01-21 17:38:39 UTC
Created attachment 97679 [details] [review] Bug 24473: Add $raw filter for Syndetics content TEST PLAN: 1. have a Syndetics account set up and turn on the Syndetics system preferences. 2. Find title(s) with Syndetics content for 'Title Notes', 'About The Author', 'Excerpt' and 'Reviews'. 3. Notice that any HTML markup displays literally. 4. Apply patch and restart_all. 5. Notice that HTML should display correctly. Created attachment 98077 [details] [review] Bug 24473: Add $raw filter for Syndetics content Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Looks like this was signed-off, but the status wasn't changed. Have changed to signed-off. Can we imagine whitelist a list of html tags? (In reply to Jonathan Druart from comment #4) > Can we imagine whitelist a list of html tags? Can you explain this a bit? I am not sure what the Syndetics code looks like, but as it's a paid for service... I hope the risk of malicious code would be small here. Cait, Syndetics sends HTML. So a description might look like this: <p>Dementors and House-elves, merpeople and Chinese Fireball Dragons--these are just a few of the magical creatures and frightening monsters populating J. K. Rowling's wizarding world. Harry Potter: The Creature Vault is a fascinating look at how this menagerie was brought to life for the blockbuster Harry Potter film series. Detailed profiles of each creature include rare concept illustrations, behind-the-scenes photography, and filmmaking secrets from the Warner Bros. archive. A removable poster picturing each of the creatures and an interactive Eeylops Owl Emporium catalog complete this must-have package.</p> Librarians would like this to $raw filter on the OPAC. (In reply to Lucas Gass from comment #6) > Cait, > > Syndetics sends HTML. So a description might look like this: > > <p>Dementors and House-elves, merpeople and Chinese Fireball Dragons--these > are just a few of the magical creatures and frightening monsters populating > J. K. Rowling's wizarding world. Harry Potter: The Creature Vault is a > fascinating look at how this menagerie was brought to life for the > blockbuster Harry Potter film series. Detailed profiles of each creature > include rare concept illustrations, behind-the-scenes photography, and > filmmaking secrets from the Warner Bros. archive. A removable poster > picturing each of the creatures and an interactive Eeylops Owl Emporium > catalog complete this must-have package.</p> > > > Librarians would like this to $raw filter on the OPAC. Hi Lucas, I understand, I was wondering about Jonathan's suggestion. Whitelisting might actually work if it's only <p> etc. but wondering if they send styling information etc. too. Leaning the way that $raw might be safer? Lucas, Is that possible to list exhaustively the different HTML tags used by this ws? Wonder if there is any technical documentation on the Syndectics API we could check - maybe there is a way to receive data without HTML? Or there are hints on what can be included. Not sure we should block this tho - You pay for Syndetics services, so it seems reasonable to assume the data will be ok. We are trying out Syndetics. One of the books contains an excerpt. The OPAC is displaying the Syndetics tags around this. e.g. <opt> <anon I1="BLANK" I2="BLANK">1 Missing Data TEXT EXCERPT HERE.... </anon> </opt> We are having issues similar to Jeremy and Katrin. What I find odd is that often for the same record, the Syndetics info will look fine for one section, say the tile notes, but display the Syndetics tags in another, such as the excerpt. I see that Stina had signed this off originally, setting back to "signed off". Created attachment 106805 [details] [review] Bug 24473: Add $raw filter for Syndetics content Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 backported to 19.11.x for 19.11.09 Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. |