| Summary: | Reword FinesMode system preference | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | System Administration | Assignee: | David Roberts <david.roberts> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, bwsdonna, david.roberts, gmcharlt, jzairo, kelly, sally.healey |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 21633 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 24475: Reword FinesMode system preference
Bug 24475: Reword FinesMode system preference error message Bug 24475: Reword FinesMode system preference Bug 24475: Reword FinesMode system preference Bug 24475: Reword FinesMode system preference Bug 24475: Cronjobs don't always live in misc |
||
|
Description
Andrew Fuerste-Henry
2020-01-21 23:27:53 UTC
Proposed wording: (Don't Calculate / Calculate and Charge / Calculate but only for mailing to the admin) fines (when misc/cronjobs/fines.pl is being run and/or CalculateFinesOnReturn is enabled). NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned. Also, while we're at it, CalculateFinesOnReturn needs a note of: NOTE: This system preference requires FinesMode to be set to "Calculate and charge." Hi Andrew, the third option doesn't work and is in process to be removed - maybe we should make this one dependent: bug 21633 I was just talking to Nick about that. I'll feel him out about an expected timeline there. This isn't strictly dependent on his change and I'd like to see this changed sooner rather than later. Have had a few libraries inadvertently make themselves fine-free by misunderstanding this. Created attachment 97954 [details] [review] Bug 24475: Reword FinesMode system preference This patch changes the wording of the FinesMode and CalculateFinesOnReturn syste m preferences explanations 1) Install Patch 2) Check that the wording of the FinesMode system preference has changed to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned." 3) Check that the wording of the CalculateFinesOnReturn system preference has changed to add "NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'" to the existing note. Working on the assumption that this is a purely cosmetic change and the actual functional changes to the system preference discussed here will be resolved elsewhere, I've changed the wording on these two system preferences. I don't think that the change I've made here will depend on the changes in bug 21633. Failing QA because the text added to CalculateFinesOnReturn has an extra period. It says : NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'. Should be: NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.' Sorry, very trivial. Thanks for writing this! Created attachment 97984 [details] [review] Bug 24475: Reword FinesMode system preference This patch changes the wording of the FinesMode and CalculateFinesOnReturn system preferences explanations 1) Install Patch 2) Check that the wording of the FinesMode system preference has changed to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned." 3) Check that the wording of the CalculateFinesOnReturn system preference has changed to add "NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'" to the existing note. Typo removed, and new patch submitted Patch doesn't apply. That's odd - it seems to apply OK on the PTFS Europe sandboxes, and on my dev server. Please can you try again? Created attachment 99003 [details]
error message
This is the error Kyle got when trying to apply this patch.
Very odd. I'll rewrite and re-submit. Thanks Tried it again on the sandbox, was unsuccessful again. Kyle tried it on his system, was also unsuccessful, and pulled out an error, which I've attached. Created attachment 101780 [details] [review] Bug 24475: Reword FinesMode system preference This patch changes the wording of the FinesMode and CalculateFinesOnReturn system preferences explanations 1) Install Patch 2) Check that the wording of the FinesMode system preference has changed to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned." 3) Check that the wording of the CalculateFinesOnReturn system preference has changed to add "NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'" to the existing note. Third time lucky (hopefully!). Created attachment 101800 [details] [review] Bug 24475: Reword FinesMode system preference This patch changes the wording of the FinesMode and CalculateFinesOnReturn system preferences explanations 1) Install Patch 2) Check that the wording of the FinesMode system preference has changed to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned." 3) Check that the wording of the CalculateFinesOnReturn system preference has changed to add "NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'" to the existing note. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 101811 [details] [review] Bug 24475: Reword FinesMode system preference This patch changes the wording of the FinesMode and CalculateFinesOnReturn system preferences explanations 1) Install Patch 2) Check that the wording of the FinesMode system preference has changed to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned." 3) Check that the wording of the CalculateFinesOnReturn system preference has changed to add "NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'" to the existing note. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 101812 [details] [review] Bug 24475: Cronjobs don't always live in misc In git installs, cronjobs live in misc, but for package installs, they live under bin. Let's just still with 'misc/cronjobs' which is always cromulent. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |