Created attachment 97697 [details] [review] Bug 24477: Require `takepayment` permission in pos/pay.pl When adding the point of sale take payment page in bug 23354 we missed the permission check script side along with adding the permission at install time (update was caught). Created attachment 97727 [details] [review] Bug 24477: Require `takepayment` permission in pos/pay.pl When adding the point of sale take payment page in bug 23354 we missed the permission check script side along with adding the permission at install time (update was caught). Created attachment 97728 [details] [review] Bug 24477: Require `takepayment` permission in pos/pay.pl When adding the point of sale take payment page in bug 23354 we missed the permission check script side along with adding the permission at install time (update was caught). Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 97729 [details] [review] Bug 24478: Use `EnablePointOfSale` preference This patch adds the `EnablePointOfSale` preference to the accounting tab on the preferences editor and ties the display of the Point of Sale module to it. Test plan: 1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences. 2) Ensure you are a superuser or your user has the takepayment permission. 3) The Point of Sale module should be present on your staff home page with the above configuration, otherwhise it should not. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 97730 [details] [review] Bug 24477: Require `takepayment` permission in pos/pay.pl When adding the point of sale take payment page in bug 23354 we missed the permission check script side along with adding the permission at install time (update was caught). Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Apologies for signoff confusion from sandboxes! No apology necessary, thanks for taking the time to look at it :) Created attachment 97780 [details] [review] Bug 24477: Require `takepayment` permission in pos/pay.pl When adding the point of sale take payment page in bug 23354 we missed the permission check script side along with adding the permission at install time (update was caught). Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Totally unrelated... but as I am running out of time: Would you be opposed to rename Purchase items to the "Debit types". I think "Purchase items" is quite confusing for translation (probably going to get mixed up with suggestions) and it seems strange to have 2 different names for the same thing. If you just go to admin, you won't find anything named this there. Nice work everyone! Pushed to master for 20.05 (In reply to Katrin Fischer from comment #9) > Totally unrelated... but as I am running out of time: Would you be opposed > to rename Purchase items to the "Debit types". I think "Purchase items" is > quite confusing for translation (probably going to get mixed up with > suggestions) and it seems strange to have 2 different names for the same > thing. If you just go to admin, you won't find anything named this there. Hmm, feel free to open that as a new bug else I'll completely forget about it.. I can see where you're coming from though I'm not entirely sure about the change. What I'd rather do is try to match the term to the flag that sets whether a debit type can be sold via the POS system vs the patron accounts pages... 'Item can be sold' I think it is. (In reply to Martin Renvoize from comment #11) > (In reply to Katrin Fischer from comment #9) > > Totally unrelated... but as I am running out of time: Would you be opposed > > to rename Purchase items to the "Debit types". I think "Purchase items" is > > quite confusing for translation (probably going to get mixed up with > > suggestions) and it seems strange to have 2 different names for the same > > thing. If you just go to admin, you won't find anything named this there. > > Hmm, feel free to open that as a new bug else I'll completely forget about > it.. > > I can see where you're coming from though I'm not entirely sure about the > change. What I'd rather do is try to match the term to the flag that sets > whether a debit type can be sold via the POS system vs the patron accounts > pages... 'Item can be sold' I think it is. No problem with opening a new bug - set this mostly as a reminder to myself. But not sure I can follow your line of thought there? I opened bug 24490 for the wording of that link and then bug 24491 suggesting some filtering options on the debit types page. (In reply to Andrew Fuerste-Henry from comment #13) > I opened bug 24490 for the wording of that link and then bug 24491 > suggesting some filtering options on the debit types page. Thx! Thanks guys, this is all really helpful feedback :) does not apply to 19.11.x. Not backported |
At the moment it appears that POS can be used without any permission - This means a patron with no permissions can access the page! my ( $template, $loggedinuser, $cookie, $user_flags ) = get_template_and_user( { template_name => 'pos/pay.tt', query => $q, type => 'intranet', authnotrequired => 0, } );