| Summary: | Make it possible to deactivate point of sale | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Fines and fees | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, andrew, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 23354 | ||
| Bug Blocks: | 23355 | ||
| Attachments: |
Bug 24478: Add `EnablePointOfSale` system preference
Bug 24478: Use `EnablePointOfSale` preference Bug 24478: Use `EnablePointOfSale` preference Bug 24477: Require `takepayment` permission in pos/pay.pl Bug 24478: Add `EnablePointOfSale` system preference Bug 24478: Use `EnablePointOfSale` preference Bug 24478: Fix sequence in syyprefs.sql and add missing comma |
||
|
Description
Katrin Fischer
2020-01-22 07:28:01 UTC
Created attachment 97702 [details] [review] Bug 24478: Add `EnablePointOfSale` system preference Created attachment 97703 [details] [review] Bug 24478: Use `EnablePointOfSale` preference This patch adds the `EnablePointOfSale` preference to the accounting tab on the preferences editor and ties the display of the Point of Sale module to it. Test plan: 1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences. 2) Ensure you are a superuser or your user has the takepayment permission. 3) The Point of Sale module should be present on your staff home page with the above configuration, otherwhise it should not. Created attachment 97732 [details] [review] Bug 24478: Use `EnablePointOfSale` preference This patch adds the `EnablePointOfSale` preference to the accounting tab on the preferences editor and ties the display of the Point of Sale module to it. Test plan: 1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences. 2) Ensure you are a superuser or your user has the takepayment permission. 3) The Point of Sale module should be present on your staff home page with the above configuration, otherwhise it should not. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=24477 Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 97733 [details] [review] Bug 24477: Require `takepayment` permission in pos/pay.pl When adding the point of sale take payment page in bug 23354 we missed the permission check script side along with adding the permission at install time (update was caught). Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 97762 [details] [review] Bug 24478: Add `EnablePointOfSale` system preference Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 97763 [details] [review] Bug 24478: Use `EnablePointOfSale` preference This patch adds the `EnablePointOfSale` preference to the accounting tab on the preferences editor and ties the display of the Point of Sale module to it. Test plan: 1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences. 2) Ensure you are a superuser or your user has the takepayment permission. 3) The Point of Sale module should be present on your staff home page with the above configuration, otherwhise it should not. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=24477 Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 97764 [details] [review] Bug 24478: Fix sequence in syyprefs.sql and add missing comma Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx Martin! 2 notes: - The QA tools don't catch if the , is missing at the end of a line in sysprefs.sql. I think it would be nice if we could add a check for that. - The pref will only control the visibility of the icon on the start page, but not access to the page. It might be nice to add a message there with a link to activate the feature. But I am not seeing this as a blocker, as what we do there is inconsistent: ILL: turn pref off = 404 Course reserves: turn pref off = nothing happens (allows to prepare for use, maybe) Nice work everyone! Pushed to master for 20.05 Enhancement not backported to 19.11 |