| Summary: | Add explanatory text to batch patron deletion | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Tools | Assignee: | David Roberts <david.roberts> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, david.roberts, hayleypelham, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.03, 19.05.08, 18.11.14
|
|
| Circulation function: | |||
| Attachments: |
Bug 24484 - Add explanatory text to batch patron deletion
Bug 24484 - Add explanatory text to batch patron deletion Bug 24484 - Add explanatory text to batch patron deletion Bug 24484: Add explanatory text to batch patron deletion |
||
|
Description
Andrew Fuerste-Henry
2020-01-22 15:03:56 UTC
Missed a word in my last bullet: "They sre in a patron category of type Staff." Created attachment 97795 [details] [review] Bug 24484 - Add explanatory text to batch patron deletion To test: 1) Open up the Batch patron deletion and anonymisation tool 2) Check the help text near the top of the screen 3) Install the patch and repeat steps 1 and 2 4) Check the help text has changed to the new version Hi David, thx for the patch! Please include the test plan in your commit message and also a small sentence as to what is changed here (see Noticed something to fix too: +<p> - They are in a patron category of type Staff..</p> should be: staff. Instead of paragraphs a bullet list might work nicer here too semantically. Then you don't need to hardcode the "- " which might be missed in translation. Forgot the link: https://wiki.koha-community.org/wiki/Commit_messages To explain that last bit... You have <p> - Stuff </p> <p> - Stuff </p> . . . <p> = Paragraph.. so it works mostly.. but semantically we're actually talking about a list so... So... <ul> <li> Stuff </li> <li> Stuff </li> </ul> This is cleaner as it's semantically describing the content more accurately.. <ul> = Unordered list, <li> = List item. :) I'm having problems adding patches with git bz attach -e - it only works without the -e at the moment, which means I can't put the test plan in the right place! Bear with me.... (In reply to David Roberts from comment #7) > I'm having problems adding patches with git bz attach -e - it only works > without the -e at the moment, which means I can't put the test plan in the > right place! Bear with me.... Hi David, you can do it like this (the -e won't help possibly): git commit --amend This will bring up the commit message of the last patch on your branch and you can edit/add to it. Then you can do a: git bz attach 24484 HEAD And then you can obsolete the old patch here using bugzilla: Klick on details > edit details > obsolete checkbox. The -e allows you to obsolete patches and change status but afaik it won't change the patch you upload. Thank you - now I understand! :-) Created attachment 97812 [details] [review] Bug 24484 - Add explanatory text to batch patron deletion This patch adds a more detailed explanation about what the tool can do. To test: 1) Open up the Batch patron deletion and anonymisation tool 2) Check the help text near the top of the screen 3) Install the patch and repeat steps 1 and 2 4) Check the help text has changed to the new version Hopefully this is better now! :-) Created attachment 97813 [details] [review] Bug 24484 - Add explanatory text to batch patron deletion This patch adds a more detailed explanation about what the tool can do. To test: 1) Open up the Batch patron deletion and anonymisation tool 2) Check the help text near the top of the screen 3) Install the patch and repeat steps 1 and 2 4) Check the help text has changed to the new version Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Thanks for jumping right on this, David! Created attachment 97943 [details] [review] Bug 24484: Add explanatory text to batch patron deletion This patch adds a more detailed explanation about what the tool can do. To test: 1) Open up the Batch patron deletion and anonymisation tool 2) Check the help text near the top of the screen 3) Install the patch and repeat steps 1 and 2 4) Check the help text has changed to the new version Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 backported to 19.05.x for 19.05.08 Backported to 18.11.x for 18.11.14. |