Summary: | AllowHoldPolicyOverride should allow Staff to override the Holds Per Record Rule | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Hold requests | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | 1joynelson, andrew, gmcharlt, lucas, martin.renvoize, nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.03, 19.05.08
|
|
Circulation function: | |||
Attachments: |
Bug 24485: Allow hold when some can be overridden
Bug 24485: Allow hold when some can be overridden Bug 24485: Allow hold when some can be overridden |
Description
Kelly McElligott
2020-01-22 15:53:05 UTC
A broader issue to this bug seems to also stem from the system preference "maxreserves". In the example below, AllowHoldPolicyOverride is set to Allow, a staff member should be able to override the Holds per Record value and also the MaxReserves system preference, however, Koha is again stopping the override from happening if it hits this system preference MaxREserves. 1. AllowHoldPolicyOverride- set to Allow 2. Circulation Rule - 500 Holds Per Record allowed 3. MaxReserve system preference set to 5. 4. Patron has 6 holds - 1 of those holds is on 1 item of a bib record. 5. Staff can not place a second item level hold on a record due to this sys pref MaxReserve value. Created attachment 98032 [details] [review] Bug 24485: Allow hold when some can be overridden The check to see if we can place a hold counts the number that we can override vs the number of items on the record. We cannot override if we already have a hold on an item, however, we don't count these to see if they plus the number of overrides equal the items on the record. To test: 1 - Set max reserves to 2, allow 2 holds per recrod 2 - Place 2 holds for a patron on some records 3 - Find another record with 2 items 4 - Place a hold on the first item, you will be notified about the limit but you can override 5 - Attempt to place hold on second item, cannot be done, button disabled 6 - Apply patch 7 - Repeat 8 - You can place the second hold Created attachment 98038 [details] [review] Bug 24485: Allow hold when some can be overridden The check to see if we can place a hold counts the number that we can override vs the number of items on the record. We cannot override if we already have a hold on an item, however, we don't count these to see if they plus the number of overrides equal the items on the record. To test: 1 - Set max reserves to 2, allow 2 holds per recrod 2 - Place 2 holds for a patron on some records 3 - Find another record with 2 items 4 - Place a hold on the first item, you will be notified about the limit but you can override 5 - Attempt to place hold on second item, cannot be done, button disabled 6 - Apply patch 7 - Repeat 8 - You can place the second hold Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 98394 [details] [review] Bug 24485: Allow hold when some can be overridden The check to see if we can place a hold counts the number that we can override vs the number of items on the record. We cannot override if we already have a hold on an item, however, we don't count these to see if they plus the number of overrides equal the items on the record. To test: 1 - Set max reserves to 2, allow 2 holds per recrod 2 - Place 2 holds for a patron on some records 3 - Find another record with 2 items 4 - Place a hold on the first item, you will be notified about the limit but you can override 5 - Attempt to place hold on second item, cannot be done, button disabled 6 - Apply patch 7 - Repeat 8 - You can place the second hold Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Code scans well and does whats expected.. simple improvement and passes qa scripts.. Passing QA Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 backported to 19.05.x for 19.05.08 |